Converge all commands into one

[sergiusens]

LP: #1567058
LP: #1567041

Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com

[sergiusens]

I am also fixing bug #1567041 here

[kyrofa]

Why would these issue warnings?

[sergiusens]

Because they are imported but not used, but by doing this you can just import snapcraft and get snapcraft.plugins and snapcraft.lifecycle already imported as well 😄

Just like you get os.path when importing os

[kyrofa]

Thanks for explaining!

[kyrofa]

Elsewhere we use a format like:

from snapcraft._store import (
    login,
    logout,
    upload
)

Should we be consistent?

[sergiusens]

Those are imported but not used, so I'd like to call them out explicitly.
It's defacto done like this for a package __init__.py

[kyrofa]

Ah, which answers my other question there, too 😃 .

[sergiusens]

I can give you a personal note here too, I don't like the way tupling looks either 😛

[kyrofa]

Let's say you imported 15 things here. How do you break the line?

[sergiusens]

With tupling, but it would also be an indication that we are doing something wrong IMHO

[kyrofa]

Just noticed this says "Exectute." Might as well fix, eh?

[sergiusens]

with what? "Executes"? Sorry I keep getting lost with these.

[kyrofa]

Just remove the extra T: s/Exectute/Execute/

[kyrofa]

Still a relative docopt newbie, but should --step be here if it's in the Usage section above? Doesn't it make it a global option, when it should really be specific to clean?

[sergiusens]

It doesn't really matter. I can break down the header (Options) into "Options for cleaning", "Options for building"
and then just Options.

Meaning of [options] shortcut slightly changed. Previously it meant "any known option". Now it means "any option not in usage-pattern". This avoids the situation when an option is allowed to be repeated unintentionally.

from the first lines of https://github.com/docopt/docopt

[kyrofa]

Does this syntax mean that --output is required when specifying <directory>, and not possible to specify when not specifying <directory>? Should this instead be snapcraft [options] snap [<directory>] [--output <snap-file>] ?

[sergiusens]

yeah, probably (and also to the snapcraft with no sub-command)

[sergiusens]

It is totally valid POSIX to do it this way, you can look at the last bullet here:
https://github.com/docopt/docopt#option-descriptions-format

Also, the tests pass and we have tests for -o and . If you think it would look nicer to put them in individual brackets that's fine, but look at git pull:

SYNOPSIS
    git pull [options] [<repository> [<refspec>...]]

[kyrofa]

Same question about the global option versus step-specific options.

[kyrofa]

Now that these are all together, should --no-parallel-build be an option specific to build?

[kyrofa]

s/snap of default/snap by default/

[sergiusens]

I wanted to say "or" but "by" is better :-)

El 07/04/16 a las 12:58, Kyle Fazzari escribió:

In snapcraft/main.py
ubuntu-core#433 (comment):

+def run(args):

• lifecycle_command = _get_lifecycle_command(args)
• argless_command = _get_command_from_arg(args)
• if lifecycle_command:

•    snapcraft.lifecycle.execute(lifecycle_command, args['<part>'])
  

• elif argless_command:

•    argless_command()
  

• elif args['clean']:

•    snapcraft.lifecycle.clean(args['<part>'], args['--step'])
  

• elif args['upload']:

•    snapcraft.upload(args['<snap-file>'])
  

• elif args['help']:

•    snapcraft.topic_help(args['<topic>'] or args['<plugin>'],
  

•                         args['--devel'], args['topics'])
  

• else: # snap of default:

s/snap of default/snap by default/

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/ubuntu-core/snapcraft/pull/433/files/71398bd40679e08f4a3233187e516894d69e7242#r58897251

[kyrofa]

Still got this.

[sergiusens]

It is totally valid POSIX to do it this way, you can look at the last bullet here:
https://github.com/docopt/docopt#option-descriptions-format

Also, the tests pass and we have tests for -o and . If you think it would look nicer to put them in individual brackets that's fine, but look at git pull:

SYNOPSIS
    git pull [options] [<repository> [<refspec>...]]

[kyrofa]

Ah, then I'm good with this. My intuition misled me 😃 .

[kyrofa]

I'm a little sad to see the commands go, but I understand the need. 👍

[sergiusens]

El 07/04/16 a las 13:24, Kyle Fazzari escribió:

I'm a little sad to see the commands go, but I understand the need. 👍

I feel the same. But it was an invitation to a problem as those commands aren't necessarily independent.