Remove `old-security`. Use proper interfaces. #441

Merged
merged 3 commits into from Apr 13, 2016

Conversation

Projects
None yet
3 participants
Collaborator

sergiusens commented Apr 12, 2016

LP: #1569452

Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com

Collaborator

sergiusens commented Apr 12, 2016

This is just best effort translation of examples. I know most won't work as is.

examples/mosquitto/snapcraft.yaml
subscribe:
command: bin/subscribe
- plugs: [listener]
+ plugs: [network]
@zyga

zyga Apr 12, 2016

Contributor

network or network-bind?

examples/mosquitto/snapcraft.yaml
- read-paths:
- - /etc/hosts.deny
- - /etc/hosts.allow
+ plugs: [network]
@zyga

zyga Apr 12, 2016

Contributor

network or network-bind?

@jdstrand

jdstrand Apr 12, 2016

If you are needing /etc/hosts.deny, you need network-bind here.

@@ -9,14 +9,7 @@ icon: icon.png
apps:
qmldemo:
command: qmlscene demo.qml --
- uses: [mir]
@zyga

zyga Apr 12, 2016

Contributor

perhaps unity7, not sure? (along with network)

@jdstrand

jdstrand Apr 12, 2016

unity7 is only for sdoc. IIRC, this is for mir in kiosk mode which will require the future mir interface.

Contributor

zyga commented Apr 12, 2016

A few suggestions for the yaml bits. Otherwise looks good. I guess we'll do a second pass when we have more interfaces and we can see what else is needed.

- 'app1': {'command': 'app1.sh'},
+ 'app1': {'command': 'app.sh'},
+ 'app2': {'command': 'app.sh', 'plugs': ['network']},
+ 'app3': {'command': 'app.sh', 'plugs': ['network-server']}
@jdstrand

jdstrand Apr 12, 2016

s/network-server/network-bind/

@jdstrand

jdstrand Apr 12, 2016

nm, I see you created a "network-server" down below so this is fine.

@sergiusens

sergiusens Apr 12, 2016

Collaborator

Yeah I network-server just to not forget about the concept of being able to do this, thanks @jdstrand .

- caps:
- - network-listener
- - network-service
- - network-management
@jdstrand

jdstrand Apr 12, 2016

Technically this would need network-control but please don't add that. Live with the denial instead until https://launchpad.net/bugs/1465724 is fixed.

Contributor

zyga commented Apr 13, 2016

Let's land it and iterate. I'm sure we'll add more interfaces and fix bugs as we go.

sergiusens added some commits Apr 12, 2016

Remove `old-security`. Use proper interfaces.
LP: #1569452

Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>

@sergiusens sergiusens merged commit 018e83e into snapcore:master Apr 13, 2016

3 of 4 checks passed

Examples tests
Details
autopkgtest Success
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.1%) to 95.985%
Details

@sergiusens sergiusens deleted the sergiusens:bugfix/1569452/migrate-to-interfaces branch Apr 13, 2016

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

Remove `old-security`. Use proper interfaces. (#441)
LP: #1569452

Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment