Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Make pull and build steps dirty if target arch changes. #450
Conversation
|
lgtm. |
sergiusens
reviewed
Apr 14, 2016
| + # step cares about, and we're comparing it to those same options in | ||
| + # the current project. If they've changed, then this step is dirty | ||
| + # and needs to run again. | ||
| + if state.project_options != state.project_options_of_interest( |
sergiusens
Apr 14, 2016
Collaborator
how about return state.project_options != state.project_options_of_interest(self._project_options) ?
kyrofa
Apr 14, 2016
Member
I previously had that on line 199 and I had to change it in order to add this section. I figured I'd just make them consistent and easy to expand.
|
lgtm, just a minor comment |
|
retest this please |
|
@kyrofa update branch? |
@sergiusens done. |
|
retest this please |
sergiusens
merged commit ab27f55
into
snapcore:master
May 24, 2016
kyrofa
deleted the
kyrofa:bugfix/1564192/track_target_arch
branch
Oct 14, 2016
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
kyrofa commentedApr 14, 2016
This PR fixes LP: #1564192 by tracking the target architecture and making the
pullandbuildsteps dirty if they change between runs. This was done in an extensible way so utilizing more project options in the state tracking would be easy.