Fix store downloading #452

Merged
merged 3 commits into from Apr 15, 2016

Conversation

Projects
None yet
2 participants
Collaborator

sergiusens commented Apr 14, 2016

No description provided.

@sergiusens sergiusens changed the title from Bugfix/1569734/store download to Fix store downloading Apr 14, 2016

Fix store downloading
LP: #1569734

Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>
libraries/generate_lib_list.py
@@ -33,7 +30,7 @@ def main():
config = load_config()
with tempfile.NamedTemporaryFile() as temp:
print('Downloading')
- download('ubuntu-core', temp.name, config, 'amd64')
+ download('ubuntu-core', 'edge', temp.name, config, 'amd64')
@kyrofa

kyrofa Apr 14, 2016

Member

Ah, I like being explicit. Edge now though, eh? We were using stable.

+ if len(pkg) != 1:
+ raise EnvironmentError(
+ 'Unexpected store result {!r}'.format(search_results))
+ download_url = pkg[0].get('anon_download_url', pkg[0]['download_url'])
@kyrofa

kyrofa Apr 14, 2016

Member

Can you explain the anon versus non-anon here?

@sergiusens

sergiusens Apr 14, 2016

Collaborator

@kyrofa it is a mess

Collaborator

sergiusens commented Apr 14, 2016

@elopio http://162.213.35.179:8080/job/github-snapcraft-autopkgtest-cloud/499/console says finished success, can we consider it a success?

Collaborator

sergiusens commented Apr 15, 2016

retest this please

@sergiusens sergiusens merged commit f5a1bf9 into snapcore:master Apr 15, 2016

2 of 4 checks passed

Examples tests Started
Details
autopkgtest Started
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.008%) to 96.05%
Details

@sergiusens sergiusens deleted the sergiusens:bugfix/1569734/store-download branch Apr 15, 2016

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

Fix store downloading (#452)
LP: #1569734

Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment