/snapcraft

Fix shell quoting #473

Merged
merged 2 commits into from Apr 19, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@sergiusens @zyga @kyrofa
@sergiusens
Collaborator

sergiusens commented Apr 19, 2016 •
Edited 1 time

"$@" is the proper way to expand original positional args; $* will
perform an extra IFS split.

LP: #1572129

Signed-off-by: Loïc Minier loic.minier@ubuntu.com
Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com

@sergiusens sergiusens referenced this pull request Apr 19, 2016

Closed

Fix run()'s shell quoting #376

@zyga
Contributor

zyga commented Apr 19, 2016

Looks good, thank you!
@kyrofa
Member

kyrofa commented Apr 19, 2016

Looks good to me 👍

sergiusens added some commits Apr 19, 2016

@sergiusens
Fix shell quoting 
"$@" is the proper way to expand original positional args; $* will
perform an extra IFS split.

LP: #1572129

Signed-off-by: Loïc Minier <loic.minier@ubuntu.com>
Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>

Some checks were not successful

2 failing and 2 successful checks
@snappy-m-o
Examples tests
Details
@snappy-m-o
autopkgtest
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage remained the same at 96.077%
Details
f890977
@sergiusens
fix SnapTestCase.test_snap

Some checks were not successful

1 failing and 3 successful checks
@snappy-m-o
Examples tests
Details
@snappy-m-o
autopkgtest — Success
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage remained the same at 96.077%
Details
46b83ba

@kyrofa kyrofa merged commit 7bfba34 into snapcore:master Apr 19, 2016
3 of 4 checks passed

3 of 4 checks passed

Examples tests
Details
autopkgtest Success
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 96.077%
Details

@sergiusens sergiusens deleted the sergiusens:bugfix/1572129/expand-exec-correctly branch Aug 30, 2016

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

@sergiusens @kyrofa
Fix shell quoting (#473) 
"$@" is the proper way to expand original positional args; $* will
perform an extra IFS split.

LP: #1572129

Signed-off-by: Loïc Minier <loic.minier@ubuntu.com>
Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>
6e1be68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment