Use colors for logging. #474

kyrofa · Apr 19, 2016

This fixes LP: #1572186 by using the following colors:

elopio · Apr 19, 2016

This is a lot better, thanks.

elopio · Apr 19, 2016

These are constants. You should use upper case letters in the var name.

Done.

elopio · Apr 19, 2016

👍
just a complaint about the var names of the constants.

kyrofa deleted the kyrofa:bugfix/1572186/use_colors branch Apr 19, 2016

-        -            '\x1b[1m'
-        -            'Login {}.'.format(result) +
-        -            '\x1b[0m\r\n')
+        +        process.expect_exact('Login {}.'.format(result))
              def logout(self):
                  output = self.run_snapcraft('logout')

+        +        'WARNING': '\033[1;33m',  # Yellow
+        +        'ERROR': '\033[0;31m',  # Dark red
+        +        'CRITICAL': '\033[1;31m',  # Light red
+        +    }

snapcore/snapcraft