Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
autopkgtests: run the install examples tests in classic #481
Conversation
|
I'm internet handicapped, so I'm throwing this to CI. Plese wait for the tests to pass before doing a final review. |
|
Looks good to me, though the autopkg tests are failing |
|
Let's better wait for my other fixes on the examples suite. Thanks for the review kyle. |
|
Eager to see you update the branch |
|
almost forgot about this. Pushed and fingers crossed. |
|
retest this please |
|
retest this please |
|
retest this please |
|
retest this please |
|
retest this please |
|
retest this please |
and others
added some commits
Apr 21, 2016
|
\o/ |
|
As I mentioned in standup I'm not a huge fan of focusing our examples on our test cases rather than as examples for developer usage, but I understand the difficulty here and I'm |
|
@kyrofa, well, we can have both. I can make it that it exits only if it receives a specific message. Care to report a bug about that? |
Good idea-- done, with a low priority. |
|
restest this please |
elopio
merged commit ca2c239
into
snapcore:master
May 13, 2016
|
\o/\o/\o/\o/\o/\o/\o/\o/\o/\o/\o/ |
elopio
deleted the
elopio:bug/1572764/isntall-on-classic
branch
May 13, 2016
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
elopio commentedApr 21, 2016
LP: #1572764