/snapcraft

nodejs plugin: Allow building N times #490

Merged
merged 1 commit into from Apr 29, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sergiusens @kyrofa
@sergiusens
Collaborator

sergiusens commented Apr 28, 2016

Doing this by not deleting the npm download.

LP: #1575882

Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com
@sergiusens
Allow building N times 
Doing this by not deleting the npm download.

LP: #1575882

Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>

All checks have passed

4 successful checks
@snappy-m-o
Examples tests — Success
Details
@snappy-m-o
autopkgtest — Success
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.0004%) to 96.161%
Details
b1d224b
@kyrofa
Member

kyrofa commented Apr 28, 2016

Looks good 👍

@kyrofa kyrofa changed the title from Allow building N times to nodejs plugin: Allow building N times Apr 28, 2016

@sergiusens
Collaborator

sergiusens commented Apr 28, 2016

retest this
@sergiusens
Collaborator

sergiusens commented Apr 28, 2016

retest this please

@sergiusens sergiusens merged commit a25b083 into snapcore:master Apr 29, 2016
4 checks passed

4 checks passed

Examples tests Success
Details
autopkgtest Success
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0004%) to 96.161%
Details

@sergiusens sergiusens deleted the sergiusens:bugfix/1575882/do-not-delete-nodejs-src branch Apr 29, 2016

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

@sergiusens
Doing this by not deleting the nodejs download. (#490) 
Doing this by not deleting the nodejs download.

LP: #1575882

Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>
5a98c2a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment