Don't fail if there is no system library list #496

Merged
merged 1 commit into from May 3, 2016

Conversation

Projects
None yet
2 participants
Collaborator

sergiusens commented May 3, 2016

LP: #1577750

Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com

Member

kyrofa commented May 3, 2016

This looks good to me, though I'm trying to decide the use-case for this. Specifically, if someone is building a snap targeting a release that doesn't exist, it's not going to work, right? Why plow ahead and build that snap instead of erroring out? Maybe my complaint is more with the bug: it doesn't really describe why what's happening right now is a problem.

Member

kyrofa commented May 3, 2016

Oh, because it's coming from the running system, I see. But shouldn't it use an exclusion list based on the target environment rather than the host? Which is still 16.04?

Don't fail if there is no system library list
LP: #1577750

Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>
Member

kyrofa commented May 3, 2016

Alright, combined with discussion on IRC, 👍 .

@sergiusens sergiusens merged commit f38b6b3 into snapcore:master May 3, 2016

4 checks passed

Examples tests Success
Details
autopkgtest Success
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.07%) to 96.242%
Details

@sergiusens sergiusens deleted the sergiusens:bugfix/1577750/libraries branch Aug 30, 2016

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

Don't fail if there is no system library list (#496)
LP: #1577750

Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment