/snapcraft

Reject plug/slot definitions at part level #503

Closed
wants to merge 1 commit into
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@zyga @kyrofa @sergiusens
@zyga
Contributor

zyga commented May 12, 2016

This patch removes incorrect schema entries that allow arbitrary plug
and slot definitions at a part level. Those definitions are ignored by
snapcraft but can cause potential confusion for users that read the
schema.

Fixes: https://bugs.launchpad.net/snapcraft/+bug/1581166
Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com
@zyga
Reject plug/slot definitions at part level 
This patch removes incorrect schema entries that allow arbitrary plug
and slot definitions at a part level. Those definitions are ignored by
snapcraft but can cause potential confusion for users that read the
schema.

Fixes: https://bugs.launchpad.net/snapcraft/+bug/1581166
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>

All checks have passed

4 successful checks
@snappy-m-o
Examples tests — Success
Details
@snappy-m-o
autopkgtest — Success
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage remained the same at 96.242%
Details
b85d8c9
@kyrofa
Member

kyrofa commented May 12, 2016 •
Edited 1 time

Thanks @zyga. Can you please change your commit message to use LP: #<bug> instead of Fixes using the URL?
@kyrofa
Member

kyrofa commented May 12, 2016 •
Edited 1 time

@zyga mind also adding a regression test? Beyond that this looks good to me, but I'm not sure why this was there initially so I invoke the @sergiusens.
@sergiusens
Collaborator

sergiusens commented May 12, 2016

I indeed 👍 this, we discussed it together. But a unit test would be nice; in snapcraft.test_yaml
@sergiusens
Collaborator

sergiusens commented May 24, 2016

Closing in favor of #514

@sergiusens sergiusens closed this May 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment