/snapcraft

Clean up the ROS example test. #505

Closed
wants to merge 5 commits into
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@elopio @kyrofa @sergiusens
@elopio
Member

elopio commented May 21, 2016

No description provided.

@elopio
Member

elopio commented May 21, 2016

retest this please
Clean up the ROS example test.

All checks have passed

4 successful checks
@snappy-m-o
Examples tests — Success
Details
@snappy-m-o
autopkgtest — Success
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage remained the same at 96.242%
Details
ed8277e
@elopio
Member

elopio commented May 21, 2016

This is related to https://bugs.launchpad.net/snapcraft/+bug/1544790
It makes the examples tests pass in the cloud. However in order to reenable them in autopkgtests we first need a proxy exception. I'm requesting it...
examples_tests/test_ros.py
@@ -0,0 +1,36 @@
+# -*- Mode:Python; indent-tabs-mode:nil; tab-width:4 -*-
+#
+# Copyright (C) 2015, 2016 Canonical Ltd
@sergiusens

sergiusens May 23, 2016

Collaborator

this should be just 2016

@elopio

elopio May 23, 2016

Member

This is code from 2015, just moved to a separate file now. So I think it should have the two years.

@elopio

elopio May 23, 2016

Member

This is code from 2015, just moved to a separate file now. So I think it should have the two years.

@elopio

elopio May 23, 2016

Member

This is code from 2015, just moved to a separate file now. So I think it should have the two years.

elopio and others added some commits May 23, 2016

@elopio
Merge branch 'master' into bug/1544790/ros_example

All checks have failed

2 failing checks
@snappy-m-o
Examples tests
Details
@snappy-m-o
autopkgtest
Details
635b8d0
@elopio
Merge branch 'master' into bug/1544790/ros_example

Some checks were not successful

1 failing and 3 successful checks
@snappy-m-o
autopkgtest
Details
@snappy-m-o
Examples tests — Success
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage remained the same at 96.268%
Details
bcfad7b
@kyrofa @sergiusens
Add support for confinement property. (#501) 
Snaps need to be able to specify if they require devmode or if they can
be run confined. This will allow for snapd to provide reasonable errors
if one tries to install a snap that cannot run successfully under
confinement. This commit adds the "confinement" property, which is
required and must be one of "enabled" or "devmode." `snapcraft init`
generates a YAML that sets "confinement" to "devmode."

LP: #1580819

Signed-off-by: Kyle Fazzari <kyle@canonical.com>

All checks have passed

2 successful checks
continuous-integration/travis-ci/push — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.02%) to 96.287%
Details
0cc9dd6
@elopio
Merge branch 'master' into bug/1544790/ros_example

Some checks were not successful

1 failing and 3 successful checks
@snappy-m-o
autopkgtest
Details
@snappy-m-o
Examples tests — Success
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage remained the same at 96.287%
Details
ed88e1f
@kyrofa
Member

kyrofa commented May 24, 2016

Closed in favor of #515

@kyrofa kyrofa closed this May 24, 2016

@elopio elopio deleted the elopio:bug/1544790/ros_example branch Jan 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment