/snapcraft

Use the in ubuntu-core python3 #510

Closed
wants to merge 5 commits into
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@sergiusens @kyrofa @elopio
@sergiusens
Collaborator

sergiusens commented May 23, 2016

LP: #1582513

Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com

kyrofa and others added some commits May 24, 2016

@kyrofa @sergiusens
Add support for confinement property. (#501) 
Snaps need to be able to specify if they require devmode or if they can
be run confined. This will allow for snapd to provide reasonable errors
if one tries to install a snap that cannot run successfully under
confinement. This commit adds the "confinement" property, which is
required and must be one of "enabled" or "devmode." `snapcraft init`
generates a YAML that sets "confinement" to "devmode."

LP: #1580819

Signed-off-by: Kyle Fazzari <kyle@canonical.com>

All checks have passed

2 successful checks
continuous-integration/travis-ci/push — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.02%) to 96.287%
Details
0cc9dd6
@sergiusens
Use the in ubuntu-core python3 
LP: #1582513

Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>
6b58c16
@sergiusens
update integration tests related to python

Some checks were not successful

1 failing and 3 successful checks
@snappy-m-o
autopkgtest
Details
@snappy-m-o
Examples tests — Success
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.004%) to 96.291%
Details
2b94a6b
snapcraft/plugins/python3.py
'python3-pkg-resources',
'python3-setuptools',
])
def env(self, root):
return [
- 'PYTHONPATH={}'.format(os.path.join(
+ 'PYTHONPATH={0}'.format(os.path.join(
@kyrofa

kyrofa May 24, 2016

Member

Is there a reason to use {0} instead of {} here?

@sergiusens

sergiusens May 24, 2016

Collaborator

left over from when I tried to use : with multiple entries, so no :-)

@sergiusens
remove positional formatting

Some checks were not successful

1 failing and 3 successful checks
@snappy-m-o
autopkgtest
Details
@snappy-m-o
Examples tests — Success
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.004%) to 96.291%
Details
26e1026
@sergiusens
Collaborator

sergiusens commented May 24, 2016

retest this please
@sergiusens
Merge branch 'master' into feature/1582513/use-in-ubuntu-core-python3

Some checks were not successful

1 failing and 3 successful checks
@snappy-m-o
Examples tests
Details
@snappy-m-o
autopkgtest — Success
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.004%) to 96.291%
Details
feb9ed0
@sergiusens
Collaborator

sergiusens commented May 24, 2016

all green 💯
@kyrofa
Member

kyrofa commented May 24, 2016

all green 💯

Can you really celebrate that when your tests look like this? 😛
@sergiusens
Collaborator

sergiusens commented May 24, 2016

@kyrofa I celebrate the fact that the infrastructure work and there was no regression! 😉
@kyrofa
Member

kyrofa commented May 24, 2016

Hahaha
@elopio
Member

elopio commented Jun 24, 2016

alright, this seems to simplify the code a lot. Do we need a review from a python/pip expert?

You need to readd the tests for py3, and rebase with master.

@sergiusens sergiusens closed this Aug 31, 2016

@sergiusens sergiusens deleted the sergiusens:feature/1582513/use-in-ubuntu-core-python3 branch Mar 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment