/snapcraft

Run the integration tests against a local fake server when the user p… #511

Merged
merged 1 commit into from May 26, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@elopio @sergiusens
@elopio
Member

elopio commented May 24, 2016

…assword is not in the environment.

LP: #1585023
@elopio
Member

elopio commented May 24, 2016

This is a branch pre-macaroons. To seed the fake servers that we will use to test parts of the store communication.

@elopio elopio referenced this pull request May 24, 2016

Closed

Move the login and logout methods to a client. #512

integration_tests/__init__.py
+ email = email or os.getenv(
+ 'TEST_USER_EMAIL', 'u1test+snapcraft@canonical.com')
+ password = password or os.getenv(
+ 'TEST_USER_PASSWORD', 'test correct password')
@sergiusens

sergiusens May 24, 2016

Collaborator

shouldn't test correct password be an empty string? Or is the self.skipTest call not needed anymore?

@elopio

elopio May 24, 2016

Member

the skip is not needed. I'll remove it.

@elopio elopio referenced this pull request May 25, 2016

Merged

Move the login and logout methods to a client. #518

@elopio
Member

elopio commented May 25, 2016

retest this please
@elopio
Member

elopio commented May 26, 2016

This is missing the fake upload server. I'm on it.
@elopio
Member

elopio commented May 26, 2016

retest this please
@elopio
Member

elopio commented May 26, 2016

retest this please
Run the integration tests against a local fake server when the user p… 
…assword is not in the environment.

LP: #1585023

All checks have passed

4 successful checks
@snappy-m-o
Examples tests — Success
Details
@snappy-m-o
autopkgtest — Success
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage decreased (-0.7%) to 95.657%
Details
d55d818
@sergiusens
Collaborator

sergiusens commented May 26, 2016

retest this please
snapcraft/tests/fake_servers.py
+ scan_complete_path = (
+ self._DEV_API_PATH + 'api/click-scan-complete/updown/')
+ if parsed_path.path.startswith(scan_complete_path):
+ self._handle_scan_complete_request()
@sergiusens

sergiusens May 26, 2016

Collaborator

@elopio for a TODO, a counter that makes the client call this at least twice.

@sergiusens
Collaborator

sergiusens commented May 26, 2016

👍

@sergiusens sergiusens merged commit e4936f3 into snapcore:master May 26, 2016
4 checks passed

4 checks passed

Examples tests Success
Details
autopkgtest Success
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.7%) to 95.657%
Details

earnubs added a commit to earnubs/snapcraft that referenced this pull request May 26, 2016

@earnubs
Merge branch 'master' of github.com:ubuntu-core/snapcraft into node-e… 
…ngine

* 'master' of github.com:ubuntu-core/snapcraft:
  Run the integration tests against a local fake server when the user password is not in the environment. (#511)
  Correct autotools tests to use configflags (#521)
3514ca1

josepht added a commit to josepht/snapcraft that referenced this pull request May 31, 2016

@elopio @josepht
Run the integration tests against a local fake server when the user p… 
…assword is not in the environment. (#511)

LP: #1585023
7bd6e38

@elopio elopio deleted the elopio:macaroons0 branch Jan 30, 2017

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

@elopio @sergiusens
Run the integration tests against a local fake server when the user p… 
…assword is not in the environment. (#511)

LP: #1585023
4b287b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment