/snapcraft

Fail validation if plugs or slots are declared at the part level #514

Merged
merged 2 commits into from May 24, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@sergiusens @kyrofa @zyga
@sergiusens
Collaborator

sergiusens commented May 24, 2016

No description provided.

zyga and others added some commits May 12, 2016

@zyga @sergiusens
Reject plug/slot definitions at part level 
This patch removes incorrect schema entries that allow arbitrary plug
and slot definitions at a part level. Those definitions are ignored by
snapcraft but can cause potential confusion for users that read the
schema.

Fixes: https://bugs.launchpad.net/snapcraft/+bug/1581166
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
0278f7c
@sergiusens
add tests 
Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>

All checks have passed

4 successful checks
@snappy-m-o
Examples tests — Success
Details
@snappy-m-o
autopkgtest — Success
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.009%) to 96.296%
Details
ead08bb

@sergiusens sergiusens referenced this pull request May 24, 2016

Closed

Reject plug/slot definitions at part level #503

@kyrofa
Member

kyrofa commented May 24, 2016 •
Edited 1 time

Looks good! 👍 . Thanks for the test 😃 .

@kyrofa kyrofa merged commit 6fabd20 into snapcore:master May 24, 2016
4 checks passed

4 checks passed

Examples tests Success
Details
autopkgtest Success
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.009%) to 96.296%
Details

@sergiusens sergiusens deleted the sergiusens:bugfix/1581166/plugs-and-slots-are-local branch May 24, 2016

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

@sergiusens @kyrofa
Fail validation if plugs or slots are declared at the part level (#514) 
This patch removes incorrect schema entries that allow arbitrary plug
and slot definitions at a part level. Those definitions are ignored by
snapcraft but can cause potential confusion for users that read the
schema.

LP: #1581166

Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>
e83d1be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment