Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Move the login and logout methods to a client. #518
Conversation
|
This is the first split of the macaroons branch. It just moves the simple login and logout methods to a client object. Requires #511. |
|
retest this please |
|
@elopio just a reminder to update the branch |
|
The unit tests are passing locally and on jenkins, but failing on travis. And travis refuses to show the output. I'm retrying... |
|
Oh, this is a case of cyclic dependencies. I had the same problem before. Travis uses python3.4 I believe and this is not handled vey well. |
sergiusens
reviewed
May 27, 2016
| + self.useFixture(fixture_setup.FakeStore()) | ||
| + self.client = storeapi.StoreClient() | ||
| + | ||
| + def test_login_successful(self): |
sergiusens
May 27, 2016
Collaborator
is there a fake server response where we use the correct password but otp is required? (just want to test the response)
elopio
May 27, 2016
Member
yes, look down:
test_failed_login_with_wrong_one_time_password
That's only in unit tests though. We could add one for integration, even hitting the staging test. I'm not sure if it adds value, but it's easy to do. File a bug if you want it, and assign it to me.
sergiusens
May 27, 2016
Collaborator
I thought an incorrect otp was different than a missing one which is required
elopio
May 27, 2016
Member
as far as I know, the answer is the same. Either an sso.ApiException or an sso.UnexpectedApiException. That is handled by the ssoclient. From our side, we just need to make sure that the success field is False.
Unless you mean something different and I misunderstood your comment.
|
|
|
restest this please |
sergiusens
merged commit 927936b
into
snapcore:master
May 27, 2016
added a commit
to josepht/snapcraft
that referenced
this pull request
May 31, 2016
elopio
deleted the
elopio:macaroons1
branch
Jun 21, 2016
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
elopio commentedMay 25, 2016
No description provided.