/snapcraft

Correct autotools documentation and tests to use configflags #521

Merged
merged 1 commit into from May 26, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@flexiondotorg @snappy-m-o @sergiusens @kyrofa
@flexiondotorg
Contributor

flexiondotorg commented May 26, 2016

As discussed in #snappy IRC on Freenode with sergiusens at 13:41:02 on 26th May 2016, here is a pull request to correct the autotools plugin documentation and a couple of test cases.
@flexiondotorg
Correct autotools tests to use configflags

All checks have passed

4 successful checks
@snappy-m-o
Examples tests — Success
Details
@snappy-m-o
autopkgtest — Success
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage remained the same at 96.311%
Details
e4cf930
@snappy-m-o

snappy-m-o commented May 26, 2016

Can one of the admins verify this patch?
@snappy-m-o

snappy-m-o commented May 26, 2016

Can one of the admins verify this patch?

@flexiondotorg flexiondotorg changed the title from Correct autotools documentation and tests and to use configflags to Correct autotools documentation and tests to use configflags May 26, 2016

@sergiusens
Collaborator

sergiusens commented May 26, 2016

OK to test
@sergiusens
Collaborator

sergiusens commented May 26, 2016

While these tests run, let me say thank you for your contribution!
@kyrofa
Member

kyrofa commented May 26, 2016

Wow, I never noticed this. 👍

@sergiusens sergiusens merged commit 465c388 into snapcore:master May 26, 2016
4 checks passed

4 checks passed

Examples tests Success
Details
autopkgtest Success
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 96.311%
Details

earnubs added a commit to earnubs/snapcraft that referenced this pull request May 26, 2016

@earnubs
Merge branch 'master' of github.com:ubuntu-core/snapcraft into node-e… 
…ngine

* 'master' of github.com:ubuntu-core/snapcraft:
  Run the integration tests against a local fake server when the user password is not in the environment. (#511)
  Correct autotools tests to use configflags (#521)
3514ca1

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

@flexiondotorg @sergiusens
Correct autotools tests to use configflags (#521)
438b921
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment