/snapcraft

Move examples to demos #522

Merged
merged 3 commits into from May 26, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@kyrofa @sergiusens @didrocks
@kyrofa
Member

kyrofa commented May 26, 2016

Superseding #506.
@didrocks @kyrofa
Move examples to demos 
Rename current examples as demos as it's more what they are about.
Ensure that CI still runs when growing a new "demos" argument and keep
examples backward compatibility until we introduce real examples as getting
started guide.

For now, we keep the snapcraft-examples package. I think this package can ship
both demos and examples.
9573ee4

@kyrofa kyrofa referenced this pull request May 26, 2016

Closed

Move examples to demos #506

kyrofa added some commits May 26, 2016

@kyrofa
Move ROS example test into demos_tests. 
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
This commit was signed with a verified signature.
@kyrofa kyrofa Kyle Fazzari
GPG key ID: A7D23FB0E778DEDF Learn about signing commits
3255e68
@kyrofa
Merge remote-tracking branch 'origin/master' into demos

All checks have passed

4 successful checks
@snappy-m-o
Examples tests — Success
Details
@snappy-m-o
autopkgtest — Success
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage remained the same at 95.66%
Details
e73141f
@sergiusens
Collaborator

sergiusens commented May 26, 2016

@kyrofa so 👍

Feel free to merge but don't forget to get a bug report in ;-)

@kyrofa kyrofa merged commit e58d857 into snapcore:master May 26, 2016
4 checks passed

4 checks passed

Examples tests Success
Details
autopkgtest Success
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 95.66%
Details

@kyrofa kyrofa deleted the kyrofa:demos branch May 26, 2016

josepht added a commit to josepht/snapcraft that referenced this pull request May 31, 2016

@kyrofa @josepht
Move examples to demos (#522) 
Rename current examples as demos as it's more what they are about.
Ensure that CI still runs when growing a new "demos" argument and keep
examples backward compatibility until we introduce real examples as getting
started guide.

For now, we keep the snapcraft-examples package. I think this package can ship
both demos and examples.

LP: #1586137

Signed-off-by: Kyle Fazzari <kyle@canonical.com>
af2bf59

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

@kyrofa
Move examples to demos (#522) 
Rename current examples as demos as it's more what they are about.
Ensure that CI still runs when growing a new "demos" argument and keep
examples backward compatibility until we introduce real examples as getting
started guide.

For now, we keep the snapcraft-examples package. I think this package can ship
both demos and examples.

LP: #1586137

Signed-off-by: Kyle Fazzari <kyle@canonical.com>
dd77887
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment