Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Support zip files as source #523
Conversation
sergiusens
added some commits
May 26, 2016
sergiusens
merged commit c9fe150
into
snapcore:master
May 26, 2016
sergiusens
deleted the
sergiusens:feature/1577062/zip-source
branch
May 26, 2016
kyrofa
reviewed
May 27, 2016
| + else: | ||
| + shutil.copy2(self.source, self.source_dir) | ||
| + | ||
| + self.provision(self.source_dir) |
kyrofa
May 27, 2016
Member
This doesn't seem to be implemented in this class. Should it be, and raise a NotImplemented or something?
sergiusens
May 27, 2016
Collaborator
I've been told lately it is not really necessary, it just needs to behave and act like a duct :-)
I am only saying this since it is tightly controlled code.
kyrofa
reviewed
May 27, 2016
| + file = os.path.join(self.source_dir, os.path.basename(self.source)) | ||
| + with open(file, 'wb') as f: | ||
| + for chunk in req.iter_content(1024): | ||
| + f.write(chunk) |
kyrofa
May 27, 2016
•
Edited 1 time
-
kyrofa
May 27, 2016
Member
Edited 1 time
-
May 27, 2016
Not for this PR, but we really need a progress bar here. Perfect use-case for one. I made a bug for it.
|
You have my retroactive |
added a commit
to josepht/snapcraft
that referenced
this pull request
May 31, 2016
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
sergiusens commentedMay 26, 2016
LP: #1577062
Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com