Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Add finale tour examples and tests #558
Conversation
didrocks
added some commits
Jun 7, 2016
|
retest this please |
|
retest this please |
|
retest this please |
|
retest this please |
elopio
reviewed
Jun 9, 2016
| @@ -160,9 +161,11 @@ def install_snap(self, snap_content_dir, snap_name, version): | ||
| self.addCleanup( | ||
| self.snappy_testbed.run_command, | ||
| ['rm', snap_path_in_testbed]) | ||
| + cmd = ['sudo', 'snap', 'install', snap_path_in_testbed] | ||
| + if devmode: | ||
| + cmd.append("--devmode") |
elopio
reviewed
Jun 9, 2016
| @@ -25,6 +25,6 @@ class EasyStartTestCase(snaps_tests.SnapsTestCase): | ||
| def test_hello(self): | ||
| self.skipTest('Skip while the proxy rule is added by IS.') |
elopio
Jun 9, 2016
Member
The rule for gnu.org was supposedly added already. I haven't tried it yet.
|
I approve too. I will fight with the tests after the meeting. |
sergiusens
merged commit 442b4f1
into
snapcore:master
Jun 9, 2016
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
didrocks commentedJun 9, 2016
They can be enabled as they are only pulling from npm and wiki parts, which are already tested elsewhere, so should work under CI jenkins firewall rules.