/snapcraft

Changed apt-get to apt in HACKING.md #564

Merged
merged 1 commit into from Jun 13, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@tsimonq2 @snappy-m-o @elopio @sergiusens
@tsimonq2
Contributor

tsimonq2 commented Jun 10, 2016 •
Edited 1 time

Sort of a misleading branch name, but this changes apt-get to apt in the HACKING.md file, which encourages people to use apt instead of apt-get.

Reported in bug 1591421: https://bugs.launchpad.net/snapcraft/+bug/1591421
@tsimonq2
* Changed apt-get to apt in HACKING.md

Some checks were not successful

1 failing and 3 successful checks
@snappy-m-o
Examples tests
Details
@snappy-m-o
autopkgtest — Success
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.05%) to 95.798%
Details
ff55bb7
@snappy-m-o

snappy-m-o commented Jun 10, 2016

Can one of the admins verify this patch?
@snappy-m-o

snappy-m-o commented Jun 10, 2016

Can one of the admins verify this patch?
@elopio
Member

elopio commented Jun 11, 2016

👍 The error is of course not caused by this change, so good to go.
@elopio
Member

elopio commented Jun 11, 2016 •
Edited 1 time

But reported in https://bugs.launchpad.net/snapcraft/+bug/1591421

@sergiusens sergiusens merged commit 14bbd1b into snapcore:master Jun 13, 2016
3 of 4 checks passed

3 of 4 checks passed

Examples tests
Details
autopkgtest Success
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.05%) to 95.798%
Details

@tsimonq2 tsimonq2 deleted the tsimonq2:apt-in-readme branch Jun 14, 2016

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

@tsimonq2 @sergiusens
Change apt-get to apt in HACKING.md (#564) 
LP: #1591421
474b157
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment