/snapcraft

Fix Snap icons for Demos #574

Merged
merged 4 commits into from Jun 22, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@RobLoach @snappy-m-o @sergiusens
@RobLoach
Contributor

RobLoach commented Jun 15, 2016

The demos use icons: in the snapcraft.yml files. This PR fixes the assets and moves the icons to setup/gui/icon.png.
@RobLoach
Fix Snap icons
This commit was signed with a verified signature.
@RobLoach RobLoach Rob Loach
GPG key ID: 627C60834A74A21A Learn about signing commits

All checks have passed

2 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage remained the same at 95.867%
Details
1083b64
@snappy-m-o

snappy-m-o commented Jun 15, 2016

Can one of the admins verify this patch?
@snappy-m-o

snappy-m-o commented Jun 15, 2016

Can one of the admins verify this patch?
@sergiusens
Collaborator

sergiusens commented Jun 21, 2016

Hi thanks for your contributions. I would like to see the icons removed complely from these as they aren't even relevant icons.

Do you mind doing that as well (instead of moving them).

RobLoach added some commits Jun 21, 2016

@RobLoach
Remove the demo setup icons
This commit was signed with a verified signature.
@RobLoach RobLoach Rob Loach
GPG key ID: 627C60834A74A21A Learn about signing commits
102fba1
@RobLoach
Merge branch 'master' of https://github.com/ubuntu-core/snapcraft int… 
…o setup-gui-icon
This commit was signed with a verified signature.
@RobLoach RobLoach Rob Loach
GPG key ID: 627C60834A74A21A Learn about signing commits

All checks have passed

4 successful checks
@snappy-m-o
Examples tests — Success
Details
@snappy-m-o
autopkgtest — Success
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage remained the same at 95.878%
Details
d384978
@RobLoach
Contributor

RobLoach commented Jun 21, 2016

@sergiusens Thanks! Deleted each one.
@sergiusens
Collaborator

sergiusens commented Jun 22, 2016

ok to test
@RobLoach
Merge branch 'master' into setup-gui-icon

Some checks were not successful

1 failing and 3 successful checks
@snappy-m-o
Examples tests
Details
@snappy-m-o
autopkgtest — Success
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage decreased (-0.05%) to 95.89%
Details
9d1596f
@sergiusens
Collaborator

sergiusens commented Jun 22, 2016

retest this please

@sergiusens sergiusens merged commit fa36e06 into snapcore:master Jun 22, 2016
3 of 4 checks passed

3 of 4 checks passed

Examples tests
Details
autopkgtest Success
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.05%) to 95.89%
Details

@RobLoach RobLoach deleted the RobLoach:setup-gui-icon branch Jun 22, 2016

@RobLoach
Contributor

RobLoach commented Jun 22, 2016

Thanks, sergiusens 👍

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

@RobLoach @sergiusens
Fix Snap icons for Demos (#574)
d022ac3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment