Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Make lxd containers ephemeral #578
Conversation
snappy-m-o
commented
Jun 17, 2016
|
Can one of the admins verify this patch? |
snappy-m-o
commented
Jun 17, 2016
|
Can one of the admins verify this patch? |
|
OK to test |
|
Thanks @evandandrea. This should have an integration test, but we have an issue pending in there, so I reported https://bugs.launchpad.net/snapcraft/+bug/1593529 for later. |
sergiusens
reviewed
Jun 17, 2016
| @@ -61,7 +61,7 @@ def _create_container(self): | ||
| remote_tmp = petname.Generate(2, '-') | ||
| check_call(['lxc', 'remote', 'add', remote_tmp, self._server]) | ||
| check_call([ | ||
| - 'lxc', 'launch', | ||
| + 'lxc', 'launch', '-e', |
|
Thanks, and terribly sorry for the slow turn around on this one |
elopio
merged commit 038bf3f
into
snapcore:master
Jun 17, 2016
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
evandandrea commentedJun 17, 2016
This fixes https://bugs.launchpad.net/snapcraft/+bug/1577548