Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Don't copy libraries that are already in prime. #580
+93
−0
Conversation
sergiusens
reviewed
Jun 18, 2016
| @@ -0,0 +1,43 @@ | ||
| +# -*- Mode:Python; indent-tabs-mode:nil; tab-width:4 -*- | ||
| +# | ||
| +# Copyright (C) 2015 Canonical Ltd |
kyrofa
Jun 20, 2016
Member
This was terrible at the very beginning of the year. I kept feeling like it was 2015, so it was fine to see it. Then in, say, February, I started catching files that contained 2015 and putting 2016 in there. Now we're like halfway through the year, and I've apparently started assuming that all the copyrights say 2016 already
|
ok to test |
|
retest this please. |
sergiusens
merged commit 00e37e5
into
snapcore:master
Jun 24, 2016
kyrofa
deleted the
kyrofa:bugfix/1570895/relative_rpath
branch
Jun 27, 2016
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
kyrofa commentedJun 17, 2016
Currently snapcraft is fooled by relative rpaths and copies linked libraries, even if they've already been primed. This PR fixes LP: #1570895 and stops that by checking each library path to ensure it hasn't already been primed before doing so.