Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Implement `snapcraft update` for parts #588
Conversation
josepht
reviewed
Jun 21, 2016
| +class _Base: | ||
| + | ||
| + def __init__(self): | ||
| + self.parts_dir = os.path.join(BaseDirectory.xdg_data_home, 'snapcraft') |
josepht
Jun 21, 2016
•
Contributor
Is it possible to have this logic in a single place? Same for "parts.yaml" and "headers.yaml".
sergiusens
Jun 21, 2016
Collaborator
If the duplication is only in the tests I actually prefer that as we would detect the change
|
Looks good to me. |
sergiusens
added some commits
Jun 21, 2016
|
retest this please |
sergiusens
added some commits
Jun 23, 2016
integration tests are failing:ERROR: test_curl_exists (test_parts.PartsTestCase) test_parts.PartsTestCase.test_curl_existstesttools.testresult.real._StringException: Traceback (most recent call last): FAIL: test_update (test_parts.PartsTestCase) test_parts.PartsTestCase.test_updatetesttools.testresult.real._StringException: Traceback (most recent call last): |
|
@elopio yeah, fix it fast, the environment mocking logic was different than in unit tests and was passing locally here as I do have a real cache enabled already |
sergiusens commentedJun 21, 2016
LP: #1594643
Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com