Improve error reporting #591

Merged
merged 4 commits into from Jun 22, 2016

Conversation

Projects
None yet
2 participants
Member

elopio commented Jun 22, 2016

This changes the way we exit on error to first log an error and then
exit with a status code of 1. The tests are updated for this new
behaviour.

A proper error when trying to upload an unexisting snap is also added.

LP: #1588023

Report an error trying to upload an unexisting snap
This changes the way we exit on error to first log an error and then
exit with a status code of 1. The tests are updated for this new
behaviour.

LP: #1588023
Member

elopio commented Jun 22, 2016

retest this please

elopio added some commits Jun 22, 2016

Member

elopio commented Jun 22, 2016

retest this please

Member

elopio commented Jun 22, 2016

retest this please

Member

elopio commented Jun 22, 2016

retest this please

@sergiusens sergiusens changed the title from Report an error trying to upload an unexisting snap to Improve error reporting Jun 22, 2016

Collaborator

sergiusens commented Jun 22, 2016

Now I need to remember to update the squash and commit message :-)

@sergiusens sergiusens merged commit b9258ea into snapcore:master Jun 22, 2016

3 of 4 checks passed

Examples tests
Details
autopkgtest Success
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.04%) to 95.942%
Details
Member

elopio commented Jun 22, 2016

This is good to go. The only error is the ros problem, not caused by this branch.

@elopio elopio deleted the elopio:bug/1588023/upload_nonexisting branch Jun 22, 2016

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

Improve error reporting (#591)
This changes the way we exit on error to first log an error and then
exit with a status code of 1. The tests are updated for this new
behaviour.

A proper error when trying to upload an unexisting snap is also added.

LP: #1588023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment