Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Improve error message logging on exit #592
Conversation
snappy-m-o
commented
Jun 22, 2016
|
Can one of the admins verify this patch? |
snappy-m-o
commented
Jun 22, 2016
|
Can one of the admins verify this patch? |
|
Needs more work, I'll hack on it more |
tsimonq2
added some commits
Jun 23, 2016
|
Hmm, the unit tests are failing, but I'm not entirely sure that it's because of tweaks I'm making. @elopio, thoughts on why this is failing? |
elopio
reviewed
Jun 23, 2016
| - | ||
| - logger.error(textwrap.fill(str(e))) | ||
| - sys.exit(1) | ||
| + sys.exit(e) |
elopio
Jun 23, 2016
Member
This is a bad merge. I changed these lines after you made your branch.
The correct merged statements would be:
logger.error(str(e))
sys.exit(1)
tsimonq2
added some commits
Jun 23, 2016
tsimonq2
changed the title from
[Trivial] Fix for bug 1574190
to
Fix for bug 1574190
Jun 23, 2016
snappy-m-o
commented
Jun 28, 2016
|
Can one of the admins verify this patch? |
snappy-m-o
commented
Jun 28, 2016
|
Can one of the admins verify this patch? |
tsimonq2
added some commits
Jun 28, 2016
|
Well, this looks like the tests have passed and the bug seems to be fixed. @elopio can you confirm that this is ready? |
|
Hey @tsimonq2 this turns into a changelog entry. Would you mind selecting a more informative PR title? |
tsimonq2
changed the title from
Fix for bug 1574190
to
Removes error message truncation (bug 1574190)
Jun 28, 2016
|
@kyrofa How does that look? |
sergiusens
changed the title from
Removes error message truncation (bug 1574190)
to
Improve error message logging
Jun 28, 2016
|
@tsimonq2 I hope you don't mind my change |
sergiusens
changed the title from
Improve error message logging
to
Improve error message logging on exit
Jun 28, 2016
|
Totally fine @sergiusens |
|
|
|
|
sergiusens
merged commit f861908
into
snapcore:master
Jun 29, 2016
tsimonq2
deleted the
tsimonq2:bug1574190
branch
Jul 10, 2016
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
tsimonq2 commentedJun 22, 2016
•
Edited 1 time
-
tsimonq2
Jun 22, 2016
This should fix bug 1574190 due to a suggestion by @elopio. This reverts a one-line change made with the commit for
cleanbuild.