python3: use --root instead of --target #614

Merged
merged 1 commit into from Jul 5, 2016

Conversation

Projects
None yet
4 participants
Contributor

jocave commented Jun 29, 2016

This should mean that entry_points defined in the setup.py get created at the expected location as well as the modules installed in usr/lib/python3/dist-packages

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Collaborator

sergiusens commented Jun 29, 2016

ok to test

Collaborator

sergiusens commented Jun 30, 2016

retest this please!!!!!!

Collaborator

sergiusens commented Jun 30, 2016

ok I am good with this code wise, I'll need to run manually unless maybe @didrocks wants to take a look and beat me to it

Contributor

didrocks commented Jul 1, 2016

Conceptually, this is indeed a way better way of installing python based modules. I'm unsure what you meant with "I'll need to run manually", do you mean the examples tests? Is CI broken and can't run them at all anymore?

Collaborator

sergiusens commented Jul 1, 2016

El 01/07/16 a las 06:21, Didier Roche escribió:

Conceptually, this is indeed a way better way of installing python based
modules. I'm unsure what you meant with "I'll need to run manually", do
you mean the examples tests? Is CI broken and can't run them at all anymore?
ci works, but I don't think we have any example that uses theses injection points.

Collaborator

sergiusens commented Jul 4, 2016

retest this please

@sergiusens sergiusens merged commit 75cb7ac into snapcore:master Jul 5, 2016

4 checks passed

Examples tests Success
Details
autopkgtest Success
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 96.239%
Details

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment