/snapcraft

Refactor and update the logic that deals with the snap-push store endpoint #632

Merged
merged 15 commits into from Jul 7, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sergiusens @kyrofa
@sergiusens
Collaborator

sergiusens commented Jul 6, 2016

No description provided.

sergiusens added some commits Jul 5, 2016

@sergiusens
WIP refactor for pushing
a005bce
@sergiusens
stage 2
aa2d999
@sergiusens
move StatusTracker, fix static fix units

All checks have failed

3 failing checks
@snappy-m-o
Examples tests
Details
@snappy-m-o
autopkgtest
Details
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
5b2ecdf
@sergiusens
Adding simplejson dep
88c8384
@sergiusens
fix static

All checks have failed

4 failing checks
@snappy-m-o
Examples tests
Details
@snappy-m-o
autopkgtest
Details
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
coverage/coveralls — Coverage decreased (-0.3%) to 96.019%
Details
f2e736d
@sergiusens
thread it

All checks have failed

4 failing checks
@snappy-m-o
Examples tests
Details
@snappy-m-o
autopkgtest
Details
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
coverage/coveralls — Coverage decreased (-0.4%) to 95.831%
Details
581e7e1
@kyrofa
Member

kyrofa commented on snapcraft/storeapi/__init__.py in 581e7e1 Jul 6, 2016

Hahahahaha

sergiusens added some commits Jul 7, 2016

@sergiusens
fine tuning

All checks have failed

4 failing checks
@snappy-m-o
Examples tests
Details
@snappy-m-o
autopkgtest
Details
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
coverage/coveralls — Coverage decreased (-0.4%) to 95.867%
Details
930b0f4
@sergiusens
Merge branch 'master' into refactor/push

All checks have failed

4 failing checks
@snappy-m-o
Examples tests
Details
@snappy-m-o
autopkgtest
Details
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
coverage/coveralls — Coverage decreased (-0.4%) to 95.873%
Details
c1056e9
@sergiusens
fix integration test

Some checks were not successful

3 failing and 1 successful checks
@snappy-m-o
Examples tests
Details
@snappy-m-o
autopkgtest
Details
coverage/coveralls — Coverage decreased (-0.4%) to 95.89%
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
9c91270
@sergiusens
error handling

All checks have failed

4 failing checks
@snappy-m-o
Examples tests
Details
@snappy-m-o
autopkgtest
Details
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
coverage/coveralls — Coverage decreased (-0.4%) to 95.844%
Details
2d4b4ac
@sergiusens
units

Some checks were not successful

2 failing and 1 successful checks
@snappy-m-o
Examples tests
Details
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
@snappy-m-o
autopkgtest — Success
Details
ae1dfe6
@sergiusens
Merge branch 'master' into refactor/push

Some checks were not successful

1 failing and 2 successful checks
@snappy-m-o
Examples tests
Details
@snappy-m-o
autopkgtest — Success
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
4f21ffb

@sergiusens sergiusens changed the title from WIP Refactor/push to Refactor the logic that deals with the snap-push store endpoint Jul 7, 2016

@sergiusens sergiusens changed the title from Refactor the logic that deals with the snap-push store endpoint to Refactor and update the logic that deals with the snap-push store endpoint Jul 7, 2016

sergiusens added some commits Jul 7, 2016

@sergiusens
Use the spec'ed text for pushing unregistered snaps 
Add tests for it as well

Some checks were not successful

2 failing and 1 successful checks
@snappy-m-o
Examples tests
Details
@snappy-m-o
autopkgtest
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
f8da782
@sergiusens
Merge branch 'master' into refactor/push

Some checks were not successful

2 failing and 1 successful checks
@snappy-m-o
Examples tests
Details
@snappy-m-o
autopkgtest
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
6823b6e
@sergiusens
oh static

Some checks were not successful

1 failing and 3 successful checks
@snappy-m-o
Examples tests
Details
@snappy-m-o
autopkgtest — Success
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.05%) to 96.337%
Details
db4bf1d
snapcraft/storeapi/__init__.py
+ thread = Thread(target=self._update_status, args=(queue,))
+ thread.start()
+
+ widgets = ['Processing...', AnimatedMarker()]
@kyrofa

kyrofa Jul 7, 2016

Member

Would it look better if there was a space between these two?

@sergiusens

sergiusens Jul 7, 2016

Collaborator

I don't know, is this a question or a statement? :-)

@kyrofa

kyrofa Jul 7, 2016

Member

Haha, a question. But you can ignore it, this looks good to me 👍 .

@sergiusens
Collaborator

sergiusens commented Jul 7, 2016

LP: #1572399 and LP: #1599953

@sergiusens sergiusens merged commit 7de1a0b into snapcore:master Jul 7, 2016
3 of 4 checks passed

3 of 4 checks passed

Examples tests
Details
autopkgtest Success
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.05%) to 96.337%
Details

@sergiusens sergiusens deleted the sergiusens:refactor/push branch Jul 7, 2016

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

@sergiusens
Refactor and update the logic that deals with the snap-push store end… 
…point (#632)

Start using the new status_details_url provided by the push store endpoint.
This also requires a small much needed refactor to be able to update the
spinner text provided for feedback.

Error scenarios wrt pushing are streamlined into proper error classes
covering cases where reviews are needed, unexpected errors occur or
pushing to a snap name that does not exist (not registered).

LP: #1572399
LP: #1599953

Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>
aff47e7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment