/snapcraft

qmake plugin: Stop doing out-of-source builds. #633

Merged
merged 3 commits into from Jul 7, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@kyrofa @elopio @sergiusens
@kyrofa
Member

kyrofa commented Jul 6, 2016

It doesn't seem well-supported and inexplicably breaks sometimes. This resolves LP: #1599572.
@kyrofa
qmake plugin: Stop doing out-of-source builds. 
It doesn't seem well-supported and inexplicably breaks sometimes.

LP: #1599572

Signed-off-by: Kyle Fazzari <kyle@canonical.com>
This commit was signed with a verified signature.
@kyrofa kyrofa Kyle Fazzari
GPG key ID: A7D23FB0E778DEDF Learn about signing commits

Some checks were not successful

2 failing and 2 successful checks
@snappy-m-o
Examples tests
Details
coverage/coveralls — Coverage decreased (-0.001%) to 96.27%
Details
@snappy-m-o
autopkgtest — Success
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
ea3fb92
@kyrofa
Member

kyrofa commented Jul 6, 2016

What is this and why is it failing here?

======================================================================

ERROR: test_parser_basic (test_parser.TestParser)

test_parser.TestParser.test_parser_basic

----------------------------------------------------------------------

testtools.testresult.real._StringException: Traceback (most recent call last):

  File "/home/travis/build/snapcore/snapcraft/integration_tests/test_parser.py", line 33, in test_parser_basic

    stdout=subprocess.DEVNULL)

  File "/usr/lib/python3.5/subprocess.py", line 581, in check_call

    raise CalledProcessError(retcode, cmd)

subprocess.CalledProcessError: Command '['/home/travis/build/snapcore/snapcraft/bin/snapcraft-parser', '--index', 'https://wiki.ubuntu.com/snapcraft/parts?action=raw', '--output', 'parts.yaml']' returned non-zero exit status 1

----------------------------------------------------------------------

kyrofa added some commits Jul 7, 2016

@kyrofa
Merge branch 'master' into bugfix/1599572/qmake_in_source_build

Some checks were not successful

3 failing and 1 successful checks
@snappy-m-o
Examples tests
Details
@snappy-m-o
autopkgtest
Details
coverage/coveralls — Coverage decreased (-0.001%) to 96.275%
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
9f50e9b
@kyrofa
Merge branch 'master' into bugfix/1599572/qmake_in_source_build

Some checks were not successful

2 failing and 2 successful checks
@snappy-m-o
Examples tests
Details
coverage/coveralls — Coverage decreased (-0.001%) to 96.287%
Details
@snappy-m-o
autopkgtest — Success
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
1e63c74
@elopio
Member

elopio commented Jul 7, 2016

retest this please
@elopio
Member

elopio commented Jul 7, 2016

retest this please
@kyrofa
Member

kyrofa commented Jul 7, 2016

retest this please

Nice try.
@elopio
Member

elopio commented Jul 7, 2016

getting closer...
@elopio
Member

elopio commented Jul 7, 2016

retest this please
@elopio
Member

elopio commented Jul 7, 2016

okay, things are moving now!
@kyrofa
Member

kyrofa commented Jul 7, 2016

retest this please
@sergiusens
Collaborator

sergiusens commented Jul 7, 2016

ok, I approve

@sergiusens sergiusens merged commit a3f85dc into snapcore:master Jul 7, 2016
2 of 4 checks passed

2 of 4 checks passed

Examples tests
Details
coverage/coveralls Coverage decreased (-0.001%) to 96.287%
Details
autopkgtest Success
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kyrofa kyrofa deleted the kyrofa:bugfix/1599572/qmake_in_source_build branch Jul 7, 2016

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

@kyrofa @sergiusens
qmake plugin: Stop doing out-of-source builds. (#633) 
It doesn't seem well-supported and inexplicably breaks sometimes.

LP: #1599572

Signed-off-by: Kyle Fazzari <kyle@canonical.com>
3d1f1c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment