Implement `snapcraft push` #653

sergiusens · Jul 13, 2016

No description provided.

josepht · Jul 13, 2016

josepht reviewed Jul 13, 2016

View changes

this should probably indicate that 'push' replaces it as well.

josepht · Jul 13, 2016

It seems strange to have 'push' accept multiple channels but 'release' only accept one. Of course that's previous work and not related to this PR. LGTM

sergiusens · Jul 13, 2016

El 13/07/16 a las 16:30, Joe Talbott escribió:

It seems strange to have 'push' accept multiple channels but 'release'
only accept one. Of course that's previous work and not related to this
PR. LGTM

I am just following the designed UX :-)

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#653 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABF_5a3uSsPRUPTDOLS0EDKLQWtOKk3Iks5qVTzCgaJpZM4JLwNR.

elopio · Jul 13, 2016

👍, minus the message in upload help that Joe mentioned.
For the future, git mv would have made the diff a lot nicer.

sergiusens · Jul 15, 2016

El 13/07/16 a las 19:40, Leo Arias escribió:

👍, minus the message in upload help that Joe mentioned.
For the future, git mv would have made the diff a lot nicer.

This was done with git mv! ;-)

sergiusens deleted the sergiusens:feature/1602788/snapcraft-push branch Jul 15, 2016

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

Implement `snapcraft push` (#653)
Keeping upload for backwards compatibility LP: #1602788 Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>

19869ae

@@ -79,7 +83,8 @@
            register     Register the package name in the store.
            tour         Setup the snapcraft examples tour in the specified directory,
                         or ./snapcraft-tour/.
-        -  upload       Upload a snap to the Ubuntu Store.
+        +  push         Pushes and optionally releases a snap to the Ubuntu Store.
+        +  upload       DEPRECATED Upload a snap to the Ubuntu Store.

snapcore/snapcraft

Implement `snapcraft push` #653

sergiusens commented Jul 13, 2016

sergiusens added some commits Jul 13, 2016

josepht reviewed Jul 13, 2016

View changes

josepht commented Jul 13, 2016

sergiusens commented Jul 13, 2016

elopio commented Jul 13, 2016

sergiusens commented Jul 15, 2016

sergiusens added some commits Jul 15, 2016

kyrofa merged commit `b174930` into snapcore:master Jul 15, 2016
4 checks passed

4 checks passed

sergiusens deleted the sergiusens:feature/1602788/snapcraft-push branch Jul 15, 2016

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

snapcore/snapcraft

Join GitHub today

Implement `snapcraft push` #653

Conversation

sergiusens commented Jul 13, 2016

sergiusens added some commits Jul 13, 2016

All checks have passed

All checks have passed

josepht reviewed Jul 13, 2016 View changes

josepht Jul 13, 2016

josepht commented Jul 13, 2016

sergiusens commented Jul 13, 2016

elopio commented Jul 13, 2016

sergiusens commented Jul 15, 2016

sergiusens added some commits Jul 15, 2016

All checks have passed

All checks have passed

Hide details View details kyrofa merged commit b174930 into snapcore:master Jul 15, 2016 4 checks passed

4 checks passed

sergiusens deleted the sergiusens:feature/1602788/snapcraft-push branch Jul 15, 2016

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

josepht reviewed Jul 13, 2016

View changes

kyrofa merged commit `b174930` into snapcore:master Jul 15, 2016
4 checks passed