Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
parser - Return non-zero code for wiki errors. #658
Conversation
|
@sergiusens I can't add or remove labels. Is that a power you can grant me? |
elopio
reviewed
Aug 5, 2016
| - return master_parts_list | ||
| + return (master_parts_list, errors) |
elopio
Aug 5, 2016
Member
I like that we are returning the number of errors, but in python we shouldn't return a tuple like in go.
Instead, if errors > 0, raise an exception. You can add an attribute to the WikiError class that's number_of_errors, so you can extract it later.
elopio
reviewed
Aug 5, 2016
| def _process_index(output): | ||
| # XXX: This can't remain in memory if the list gets very large, but it | ||
| # should be okay for now. | ||
| master_parts_list = OrderedDict() | ||
| + errors = dict(wiki=0) |
elopio
Aug 5, 2016
Member
I got lost with this. Do we have any other kind of errors? Why isn't it just a counter?
josepht
Aug 9, 2016
Contributor
The thinking is that we'd have at least two classes of errors; 1. wiki entry errors (i.e. malformed yaml, missing fields, etc.) 2. snapcraft.yaml errors that make constructing the fully parsed part impossible. For either one we want to be able to continue processing the subsequent entries. I'll look into handling this with exceptions.
|
Looks good, can you add a unit test showing this wiki parsing problem count? |
josepht
added some commits
Jul 14, 2016
|
retest this please |
kyrofa
reviewed
Aug 12, 2016
| part_name = data.get('project-part') | ||
| if part_name is not None and part_name in master_parts_list: | ||
| logger.warning("Duplicate part found in wiki: {}".format( | ||
| part_name)) | ||
| - return | ||
| + raise InvalidEntryError('duplicate entry: {}'.format(entry)) |
kyrofa
Aug 12, 2016
Member
Also, the warning and exception messages are redundant. Perhaps it would be better to only raise here, and log in the catcher of the exception instead?
kyrofa
reviewed
Aug 12, 2016
| @@ -722,11 +727,6 @@ def test_carriage_returns(self, mock_get, mock_get_origin_data): | ||
| origin: lp:snapcraft-parser-example | ||
| description: example main | ||
| project-part: main\r | ||
| ---- | ||
| -maintainer: Jim Doe <jim.doe@example.com> |
josepht
added some commits
Aug 12, 2016
sergiusens
merged commit bda3b10
into
snapcore:master
Aug 16, 2016
josepht
deleted the
josepht:bugs/1602394
branch
Aug 19, 2016
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
josepht commentedJul 14, 2016
LP:#1602394
Signed-off-by: Joe Talbott joe.talbott@ubuntu.com