/snapcraft

Strip common path prefixes from linkname as well as name when extracting a tarfile #688

Merged
merged 7 commits into from Aug 3, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@mhall119 @snappy-m-o @kyrofa @sergiusens
@mhall119
Contributor

mhall119 commented Jul 26, 2016

Stripping common path prefixes from the member name breaks hardlink name resolution unless you perform the same operation on the member linknames
@mhall119
Stripping common path prefixes from the member name breaks hardlink n… 
…ame resolution unless you perform the same operation on the member linknames

All checks have failed

2 failing checks
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
coverage/coveralls — Coverage decreased (-0.008%) to 96.566%
Details
b5678d7
@snappy-m-o

snappy-m-o commented Jul 26, 2016

Can one of the admins verify this patch?
@snappy-m-o

snappy-m-o commented Jul 26, 2016

Can one of the admins verify this patch?
@kyrofa
Member

kyrofa commented Jul 28, 2016

@mhall119 according to the integration tests, this seems to bust the nodejs and rust plugins.

mhall119 added some commits Aug 1, 2016

@mhall119
Merge branch 'master' of github.com:snapcore/snapcraft into bug/16067… 
…00/tarfile_hardlinks
7c825da
@mhall119
Only rewrite link names for hardlinks (not symlinks)

All checks have failed

2 failing checks
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
coverage/coveralls — Coverage decreased (-0.02%) to 96.779%
Details
4229a34
@mhall119
cleanup code comments

All checks have failed

2 failing checks
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
coverage/coveralls — Coverage decreased (-0.02%) to 96.779%
Details
c81afa6
@mhall119
de-complexify Tar._extract
effb2b8
@mhall119
Add test cases for stripping path prefixes when extracting tar files,… 
… including with symlinks and hardlinks
7dcbb25
@mhall119
Use relative paths for symlinks when testing tar plugin

All checks have passed

4 successful checks
@snappy-m-o
autopkgtest integration — Success
Details
@snappy-m-o
autopkgtest snaps — Success
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.02%) to 96.824%
Details
63873a9
@kyrofa
Member

kyrofa commented Aug 1, 2016

ok to test

@sergiusens sergiusens merged commit 9b240ef into snapcore:master Aug 3, 2016
4 checks passed

4 checks passed

autopkgtest integration Success
Details
autopkgtest snaps Success
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 96.824%
Details

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

@mhall119 @sergiusens
Strip common path prefixes from linkname as well as name when extract… 
…ing a tarfile (#688)

Stripping common path prefixes from the member name breaks hardlink name resolution unless you perform the same operation on the member linknames

LP: #1606700
092aee8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment