Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Add godeps plugin. #691
Conversation
kyrofa
reviewed
Jul 27, 2016
| + 'ant catkin copy godeps gulp kbuild make nil ' | ||
| + 'plainbox-provider python3 rust tar-content\n' | ||
| + 'autotools cmake go gradle jdk kernel maven nodejs ' | ||
| + 'python2 qmake scons\n') |
This commit was signed with a verified signature.
kyrofa
Kyle Fazzari
elopio
reviewed
Jul 27, 2016
| + 'autotools godeps kernel plainbox-provider scons \n' | ||
| + 'catkin gradle make python2 tar-content\n' | ||
| + 'cmake gulp maven python3 \n' | ||
| + 'copy jdk nil qmake \n') |
|
|
sergiusens
reviewed
Jul 28, 2016
| + Path to the godeps dependencies file contained within the source | ||
| + (default: dependencies.tsv) | ||
| + | ||
| + - go-importpath: |
sergiusens
reviewed
Jul 28, 2016
| + if self.options.go_importpath: | ||
| + go_package = self.options.go_importpath | ||
| + else: | ||
| + logger.warning( |
sergiusens
reviewed
Jul 28, 2016
| + env['GOPATH'] = self._gopath | ||
| + env['PATH'] = '{}:{}'.format( | ||
| + os.path.join(self._gopath, 'bin'), env.get('PATH', '')) | ||
| + linker_flags = ' '.join([ |
sergiusens
Jul 28, 2016
•
Edited 1 time
-
sergiusens
Jul 28, 2016
Collaborator
Edited 1 time
-
Jul 28, 2016
can't you retrieve this from common, I bet you also want the stage ones here (to link against dependant parts)
kyrofa
Jul 28, 2016
Member
Haha, I completely forgot about those functions already! How sad. Definitely should use them here-- done.
kyrofa
added some commits
Jul 28, 2016
stevenwilkin
referenced this pull request
in snapcore/snapweb
Jul 29, 2016
Merged
[WIP] Use Snapcraft to build snap #4
nskaggs
commented
Aug 2, 2016
|
+1 from me. Tested and working for building juju. This made my juju snapcraft.yaml file much simpler, and added tags support! Thanks! |
|
|
sergiusens
merged commit a073503
into
snapcore:master
Aug 2, 2016
kyrofa
deleted the
kyrofa:feature/1595981/godeps
branch
Oct 14, 2016
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
kyrofa commentedJul 27, 2016
Snapcraft currently has a go plugin, but go has a number of dependency management systems. One very common one is godeps. This PR resolves LP: #1595981 by adding a plugin for it.