Also use INSTALLROOT for make plugin. #697

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

jhobbs commented Jul 29, 2016

Some projects don't use DESTDIR - it's only a gnu convention. make will ignore arguments that aren't used, so appending is cleaner than exposing a new option on the command line, and just works.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Collaborator

sergiusens commented Jul 29, 2016

ok to test

Contributor

jhobbs commented Aug 2, 2016

What do I do now? I can't access the autopkgtest results. I didn't make any changes that would have broken packaging...

Contributor

jhobbs commented Aug 2, 2016

ok!

Collaborator

sergiusens commented Aug 3, 2016

Should we piggy back every other option or implement something like this https://bugs.launchpad.net/snapcraft/+bug/1609116 ?

Collaborator

sergiusens commented Aug 4, 2016

I am closing this one in favor of #711 which will handle more cases. Please reopen if you think it is a mistake.

@sergiusens sergiusens closed this Aug 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment