/snapcraft

Use the proper requirements.txt path #707

Merged
merged 4 commits into from Aug 4, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sergiusens @kyrofa
@sergiusens
Collaborator

sergiusens commented Aug 2, 2016

fix the implementation to look for requirements.txt in the
part's source dir.

LP: #1588855

Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com
@sergiusens
Use the proper requirements.txt path 
fix the implementation to look for requirements.txt in the
part's source dir.

LP: #1588855

Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>

Some checks were not successful

3 failing and 1 successful checks
@snappy-m-o
autopkgtest integration
Details
@snappy-m-o
autopkgtest snaps
Details
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
coverage/coveralls — Coverage increased (+0.2%) to 97.202%
Details
4ee1860
@kyrofa
Member

kyrofa commented Aug 2, 2016

Nice, looks good 👍

sergiusens added some commits Aug 3, 2016

@sergiusens
add source entries to support requirement files in the integration tests

All checks have passed

3 successful checks
@snappy-m-o
autopkgtest integration — Success
Details
@snappy-m-o
autopkgtest snaps — Success
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
9611f1f
@sergiusens
Merge branch 'master' into bugfix/1588855/no-requirement-left-behind

All checks have passed

3 successful checks
@snappy-m-o
autopkgtest integration — Success
Details
@snappy-m-o
autopkgtest snaps — Success
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
1e3c794
@sergiusens
fix static

All checks have passed

4 successful checks
@snappy-m-o
autopkgtest integration — Success
Details
@snappy-m-o
autopkgtest snaps — Success
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.2%) to 97.312%
Details
33d1adf
integration_tests/snaps/pip-requirements-file/snapcraft.yaml
@@ -11,7 +11,9 @@ confinement: strict
parts:
python2:
plugin: python2
+ source: .
@kyrofa

kyrofa Aug 4, 2016

Member

Hmm... should this be required, now?

@kyrofa

kyrofa Aug 4, 2016

Member

Well no, I guess not since we have python-packages, but could we toss an obvious error if requirements is used without source?

@sergiusens

sergiusens Aug 4, 2016

Collaborator

@kyrofa I plan to solve than when I deal with the culprit for https://bugs.launchpad.net/snapcraft/+bug/1606894

@kyrofa

kyrofa Aug 4, 2016

Member

Ah, very good.

@sergiusens sergiusens merged commit b19ffe6 into snapcore:master Aug 4, 2016
4 checks passed

4 checks passed

autopkgtest integration Success
Details
autopkgtest snaps Success
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 97.312%
Details

@sergiusens sergiusens deleted the sergiusens:bugfix/1588855/no-requirement-left-behind branch Aug 4, 2016

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

@sergiusens
Use the proper requirements.txt path (#707) 
LP: #1588855

Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>
957b78e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment