Use the proper requirements.txt path #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix the implementation to look for requirements.txt in the part's source dir. LP: #1588855 Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>
|
Nice, looks good 👍 |
| @@ -11,7 +11,9 @@ confinement: strict | |||
| parts: | |||
| python2: | |||
| plugin: python2 | |||
| source: . | |||
There was a problem hiding this comment.
Hmm... should this be required, now?
There was a problem hiding this comment.
Well no, I guess not since we have python-packages, but could we toss an obvious error if requirements is used without source?
There was a problem hiding this comment.
@kyrofa I plan to solve than when I deal with the culprit for https://bugs.launchpad.net/snapcraft/+bug/1606894
kalikiana
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
LP: #1588855 Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the implementation to look for requirements.txt in the
part's source dir.
LP: #1588855
Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com