/snapcraft

kernel plugin: vmlinuz -> kernel.img hard link #748

Merged
merged 4 commits into from Aug 31, 2016
+2 −3

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@piso77 @sergiusens @kyrofa
@piso77
Contributor

piso77 commented Aug 22, 2016

Adhere to the new naming scheme decided in Heidelberg, and create a kernel.img copy of vmlinuz.

Signed-off-by: Paolo Pisati paolo.pisati@canonical.com
kernel plugin: vmlinuz -> kernel.img hard link 
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>

All checks have passed

4 successful checks
@snappy-m-o
autopkgtest integration — Success
Details
@snappy-m-o
autopkgtest snaps — Success
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.0002%) to 97.458%
Details
7d428ea
@sergiusens
Collaborator

sergiusens commented Aug 22, 2016

Can you update the unit tests for this case?
kernel plugin: vmlinuz -> kernel.img unit test 
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>

Some checks were not successful

1 failing and 3 successful checks
@snappy-m-o
autopkgtest snaps
Details
@snappy-m-o
autopkgtest integration — Success
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.0002%) to 97.458%
Details
7515e3b
snapcraft/plugins/kernel.py
@@ -311,6 +311,7 @@ def _copy_vmlinuz(self):
os.link(src, dst)
# why oh why?
os.link(src, os.path.join(self.installdir, 'vmlinuz'))
@sergiusens

sergiusens Aug 24, 2016

Collaborator

do we still need this line?

@kyrofa

kyrofa Aug 24, 2016

Member

And should they be link_or_copies?

@sergiusens

sergiusens Aug 24, 2016

Collaborator

that should come later if needed. This plugin is full of os.link calls ;-)

kernel plugin: remove vmlinuz hard link 
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>

Some checks were not successful

1 failing and 2 successful checks
@snappy-m-o
autopkgtest snaps
Details
@snappy-m-o
autopkgtest integration — Success
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
c76fca1
@piso77
Contributor

piso77 commented Aug 31, 2016

Ok, i removed the vmlinuz hard link, the comment and i've pushed again - once this get in, we might rewrite to use symlinks instead of hard links.
@piso77
Merge branch 'master' into kernel_dot_img_rename

All checks have passed

4 successful checks
@snappy-m-o
autopkgtest integration — Success
Details
@snappy-m-o
autopkgtest snaps — Success
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage remained the same at 97.899%
Details
1145ebc

@sergiusens sergiusens merged commit f77341d into snapcore:master Aug 31, 2016
4 checks passed

4 checks passed

autopkgtest integration Success
Details
autopkgtest snaps Success
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 97.899%
Details

@piso77 piso77 deleted the piso77:kernel_dot_img_rename branch Feb 17, 2017

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

@piso77 @sergiusens
kernel plugin: vmlinuz -> kernel.img hard link (#748) 
LP: #1618019

Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
abc9867
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment