Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python plugin: only download in pull and build in build. #832

Merged
merged 6 commits into from Sep 29, 2016
Merged

python plugin: only download in pull and build in build. #832

merged 6 commits into from Sep 29, 2016

Conversation

sergiusens
Copy link
Collaborator

@sergiusens sergiusens commented Sep 27, 2016 •
edited

LP: #1627880

@sergiusens sergiusens changed the title WIP LP: #1627880 python plugin: only download in pull and build in build. Sep 27, 2016
kyrofa
kyrofa approved these changes Sep 29, 2016
View reviewed changes
Copy link
Contributor

@kyrofa kyrofa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, and solved my build issues 👍 .

@sergiusens
Copy link
Collaborator Author

Great, @cwayne18 also gave an irc +1

@sergiusens sergiusens merged commit db5e7df into canonical:master Sep 29, 2016
@sergiusens sergiusens deleted the bugfix/1627880/pip-phases branch September 29, 2016 17:10
kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017
@sergiusens
python plugin: only download in pull and build in build. (canonical#832)
539dc00 
With this change the `pull` step is a real `pull` step and the actual building is done only in the `build` step.

LP: #1627880
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyrofa kyrofa kyrofa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sergiusens @kyrofa