/snapcraft

python plugin: only download in pull and build in build. #832

Merged
merged 6 commits into from Sep 29, 2016

Conversation

Reviewers

@kyrofa kyrofa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sergiusens @kyrofa
@sergiusens
Collaborator

sergiusens commented Sep 27, 2016 •
Edited 1 time

LP: #1627880

sergiusens added some commits Sep 27, 2016

@sergiusens
stage 1
ac01b72
@sergiusens
download

Some checks were not successful

4 failing and 2 successful checks
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
coverage/coveralls — Coverage decreased (-0.02%) to 98.108%
Details
@snappy-m-o
xenial autopkgtest integration
Details
@snappy-m-o
yakkety autopkgtest integration
Details
@snappy-m-o
xenial autopkgtest snaps — Success
Details
@snappy-m-o
yakkety autopkgtest snaps — Success
Details
b412fff
@sergiusens
We now only download in pull for the python plugin 
integration tests should now build.

Some checks were not successful

1 failing and 5 successful checks
coverage/coveralls — Coverage decreased (-0.02%) to 98.108%
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
@snappy-m-o
xenial autopkgtest integration — Success
Details
@snappy-m-o
xenial autopkgtest snaps — Success
Details
@snappy-m-o
yakkety autopkgtest integration — Success
Details
@snappy-m-o
yakkety autopkgtest snaps — Success
Details
1629bdc
@sergiusens
ut

All checks have passed

6 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.007%) to 98.14%
Details
@snappy-m-o
xenial autopkgtest integration — Success
Details
@snappy-m-o
xenial autopkgtest snaps — Success
Details
@snappy-m-o
yakkety autopkgtest integration — Success
Details
@snappy-m-o
yakkety autopkgtest snaps — Success
Details
f35102e
@sergiusens
Merge branch 'master' into bugfix/1627880/pip-phases

All checks have passed

6 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.007%) to 98.14%
Details
@snappy-m-o
xenial autopkgtest integration — Success
Details
@snappy-m-o
xenial autopkgtest snaps — Success
Details
@snappy-m-o
yakkety autopkgtest integration — Success
Details
@snappy-m-o
yakkety autopkgtest snaps — Success
Details
df08285

@sergiusens sergiusens changed the title from WIP LP: #1627880 to python plugin: only download in pull and build in build. Sep 27, 2016

@sergiusens
add missing flags for wheel

All checks have passed

6 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.007%) to 98.14%
Details
@snappy-m-o
xenial autopkgtest integration — Success
Details
@snappy-m-o
xenial autopkgtest snaps — Success
Details
@snappy-m-o
yakkety autopkgtest integration — Success
Details
@snappy-m-o
yakkety autopkgtest snaps — Success
Details
7db23b1
@kyrofa

kyrofa approved these changes Sep 29, 2016
View changes

This looks good to me, and solved my build issues 👍 .

@sergiusens
Collaborator

sergiusens commented Sep 29, 2016

Great, @cwayne18 also gave an irc +1

@sergiusens sergiusens merged commit db5e7df into snapcore:master Sep 29, 2016
6 checks passed

6 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.007%) to 98.14%
Details
xenial autopkgtest integration Success
Details
xenial autopkgtest snaps Success
Details
yakkety autopkgtest integration Success
Details
yakkety autopkgtest snaps Success
Details

@sergiusens sergiusens deleted the sergiusens:bugfix/1627880/pip-phases branch Sep 29, 2016

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

@sergiusens
python plugin: only download in pull and build in build. (#832) 
With this change the `pull` step is a real `pull` step and the actual building is done only in the `build` step.

LP: #1627880
539dc00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment