Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Fixing 'sign-build' integration tests. #839
Conversation
sergiusens
requested changes
Sep 29, 2016
Looks like a nice improvement. I do however suspect these tests have not run.
| @@ -26,6 +26,8 @@ | ||
| Not, | ||
| ) | ||
| +import integration_tests |
| - self.assertThat(self.snap_build_path, FileExists()) | ||
| - self.assertThat(self.snap_build_path, | ||
| + | ||
| + snap_build_path = '{}-build'.format(snap_path) |
cprov
Sep 29, 2016
Contributor
It was, the test works if the account logged in was the publisher of 'basic' name, but this is impossible in staging SCA. See https://travis-ci.org/snapcore/snapcraft/builds/163606844
| self.send_response(201) | ||
| self.send_header('Content-Type', 'application/json') | ||
| self.end_headers() | ||
| response = {'snap_id': 'test-snap-id'} | ||
| + self.server.regitered_name |
cprov
Sep 29, 2016
Contributor
The intention was to leave no doubts this was a 2am PR ;-) typo removed.
sergiusens
merged commit b67a60d
into
snapcore:master
Sep 29, 2016
cprov
deleted the
cprov:test-skipping
branch
Sep 29, 2016
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
cprov commentedSep 29, 2016
Even for building the local assertion, the command actually checks if the
account logged in has upload permission on the targeted snap (resolving
name to snap-id via account-info).
The test now builds an random snap, register the name in the store and
only then signs the snap. The fake server was extended to record registered
names and return them in the account-info endpoint.