Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Add nil plugin #85
Conversation
sergiusens
reviewed
Nov 6, 2015
| +# You should have received a copy of the GNU General Public License | ||
| +# along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| + | ||
| +"""The nil plugin is useful for parts with entirely optional properties. |
sergiusens
reviewed
Nov 6, 2015
| @@ -91,6 +91,7 @@ def test_list_plugins(self, mock_stdout): | ||
| jdk | ||
| make | ||
| maven | ||
| +nil |
sergiusens
Nov 6, 2015
Collaborator
there is an integration test with a similar test you would need to update
sergiusens
reviewed
Nov 6, 2015
| +name: test-package | ||
| +version: 0.1 | ||
| +vendor: Jonathan Cave <jonathan.cave@canonical.com> | ||
| +summary: one line summary |
sergiusens
reviewed
Nov 6, 2015
| +version: 0.1 | ||
| +vendor: Jonathan Cave <jonathan.cave@canonical.com> | ||
| +summary: one line summary | ||
| +description: a longer description |
sergiusens
Nov 6, 2015
Collaborator
use description for a longer description of the objective of the test
|
Thanks for this, I made some in source comments Additionally, can you remove the icon and just do Additionally, I'd like @elopio to comment on the integration test, I think a test to see that it is indeed |
|
Conflict prevent merging this, care to check? |
sergiusens
reviewed
Nov 10, 2015
| @@ -401,17 +400,3 @@ command: | ||
| ${SNAPCRAFT} shell xml2-config --cflags | grep -q `pwd` | ||
| ${SNAPCRAFT} shell xslt-config --cflags | grep -q `pwd` | ||
| flags: simple has-leftovers | ||
| - |
jocave
added some commits
Nov 6, 2015
added a commit
that referenced
this pull request
Nov 13, 2015
sergiusens
merged commit 8e62b40
into
snapcore:master
Nov 13, 2015
jocave
deleted the
jocave:plugin-nil
branch
Mar 2, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
jocave commentedNov 6, 2015
The nil plugin is for parts in which all properties are optional.