tests: fix integration tests in armhf #971

Merged
merged 11 commits into from Jan 3, 2017

Conversation

Projects
None yet
3 participants
Member

elopio commented Dec 14, 2016

LP: #1649899

Member

elopio commented Dec 14, 2016

WIP

codecov-io commented Dec 14, 2016

Current coverage is 96.39% (diff: 100%)

Merging #971 into master will not change coverage

@@             master       #971   diff @@
==========================================
  Files           190        190          
  Lines         16926      16926          
  Methods           0          0          
  Messages          0          0          
  Branches       1292       1292          
==========================================
  Hits          16316      16316          
  Misses          418        418          
  Partials        192        192          

Powered by Codecov. Last update b4e53f8...343544f

elopio and others added some commits Dec 14, 2016

Collaborator

sergiusens commented Dec 16, 2016

ok, next week task for @kyrofa

Member

elopio commented Dec 16, 2016

damn it!

Member

elopio commented Dec 16, 2016

Temporary failure in name resolution. I'll retry later.

Collaborator

sergiusens commented Dec 16, 2016

Member

elopio commented Dec 16, 2016

No, I agree. I would like you to dput as early as possible, to start my holidays today :) I yelled at the elders of the internet, not at you.

elopio added some commits Dec 19, 2016

@sergiusens sergiusens changed the title from Fix integration tests in armhf to tests: fix integration tests in armhf Jan 3, 2017

elopio added some commits Jan 3, 2017

Collaborator

sergiusens commented Jan 3, 2017

I would avoid usage of platform.machine as much as possible and use project_options in the future as this detection is bound to change in the future given that we care about the userspace and not the cpu as proved by the foundations team

@sergiusens sergiusens merged commit a725e69 into snapcore:master Jan 3, 2017

5 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
xenial-amd64 autopkgtest finished (success)
Details
xenial-armhf autopkgtest finished (success)
Details
yakkety-amd64 autopkgtest finished (success)
Details
zesty-amd64 autopkgtest finished (success)
Details

@elopio elopio deleted the elopio:armhf_integration branch Jan 3, 2017

Member

elopio commented Jan 3, 2017

💃

Member

elopio commented Jan 3, 2017

@sergiusens we don't have access to the project options from these tests. Should snapcraft offer a way to retrieve that?

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment