Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
pluginhandler: add support for disabling system library migration #989
Conversation
|
More than |
Works for me-- done. |
codecov-io
commented
Dec 16, 2016
•
Current coverage is 96.40% (diff: 100%)@@ master #989 diff @@
==========================================
Files 190 192 +2
Lines 16926 16962 +36
Methods 0 0
Messages 0 0
Branches 1292 1293 +1
==========================================
+ Hits 16316 16352 +36
Misses 418 418
Partials 192 192
|
sergiusens
requested changes
Jan 3, 2017
Looks good, the in-code and md documentation needs to be updated to add this though.
sergiusens
changed the title from
Add support for disabling system library migration.
to
pluginhandler: add support for disabling system library migration
Jan 3, 2017
kyrofa
added some commits
Jan 3, 2017
Ah of course! Done. |
sergiusens
merged commit 54aa0ec
into
snapcore:master
Jan 4, 2017
kyrofa
deleted the
kyrofa:feature/1639831/support_no_ldd_crawling
branch
Jan 5, 2017
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
kyrofa commentedDec 15, 2016
•
Edited 1 time
-
kyrofa
Dec 16, 2016
Currently snapcraft, during the prime step for a part, checks to see if that part needs any libraries from the system. This is not always desired, as in some cases the libraries will be provided by another snap via the content interface.
This PR fixes LP: #1639831 by introducing a new property to the base part YAML:
build-attributes. It's simply a list of build attributes, only one of which exists right now:no-system-libraries. For example:Using the
no-system-librariesattribute has the effect of not pulling any libraries from the system during the prime step for that part.