Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Add API to control whether polkit authorisation checks allow interaction #14
Conversation
jhenstridge
referenced this pull request
in snapcore/snapd
Aug 25, 2017
Merged
daemon: allow polkit authorisation to install/remove snaps #3797
|
Looks good to me, happy to merge once snapd approves the use of this field. |
|
I brought over some of your test case changes into master, so this branch will have to be rebased again. |
jhenstridge
added some commits
Aug 24, 2017
|
I've updated the branch, also changing the value we set the request header to, as requested in the snapd PR. |
robert-ancell
merged commit 5453355
into
snapcore:master
Sep 4, 2017
|
I squashed the commits and fixed up some documentation issues in master for this, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
jhenstridge commentedAug 24, 2017
This branch is intended to complement snapcore/snapd#3795 by adding
set_allow_interactionandget_allow_interactionAPIs toSnapdClient. The idea is to let the client decide whether snapd's polkit authorisation checks should allow interaction or not.One question is what the default should be for snapd-glib. At present I've set it to default to allow interaction on the assumption that most users of the library will be graphical. But it would be pretty easy to disallow interaction by default.
The change should be backward compatible with old versions of snapd: they will simply ignore the extra request header.