Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
interfaces: bluez: fix dbus rules #1037
Conversation
and others
added some commits
Apr 17, 2016
|
Looks good |
|
Looks like the autopkgtest is hitting some issues downloading snaps. I don't think this is something my branch could have caused, but you're the expert @zyga |
|
Tested this with the snap from https://code.launchpad.net/~ssweeny/+snap/bluez/+build/601 in KVM instance having a BT dongle connect. Works fine, see https://paste.ubuntu.com/15931839/ for details. |
niemeyer
reviewed
Apr 20, 2016
| @@ -91,7 +96,7 @@ var bluezConnectedPlugAppArmor = []byte(` | ||
| # Allow all access to bluez service | ||
| dbus (receive, send) | ||
| bus=system | ||
| - peer=(label=bluez5_bluez_*), | ||
| + peer=(label=snap.bluez.*), |
niemeyer
Apr 20, 2016
Contributor
This is hard-coding an interface to be used by a specifically named snap, which doesn't seem to make sense for an interface in a platform.
@zyga can you please work with him to ensure we have the proper content in this template? I thought we had already discussed this last week?
morphis
Apr 21, 2016
Contributor
From what I got the agreement was that we go with this until we have a proper mechanism in place (which @zyga and @jdstrand are working on) to replace the peer label with the correct label from the connected plug.
ssweeny
Apr 21, 2016
Contributor
This was my understanding as well. With this fix we can have a working bluez snap in the store today (as opposed to the broken one that's in there now) while we wait on the proper fix.
jdstrand
Apr 21, 2016
•
Contributor
I agree with Gustavo but in the interest of time if people want to fix bluez (and network-manager) quickly, I would be ok with this but please add a comment:
FIXME: adjust to use 'snap..' from the connecting slot
|
That doesn't seem to reflect the conversation we had last week about this problem. |
ssweeny
added some commits
Apr 21, 2016
|
I'm working on improving interface details now |
zyga
added some commits
Apr 25, 2016
ssweeny
added some commits
Apr 25, 2016
|
@ssweeny Thanks. Once we have this here I will do the same for the networkmanager interface |
|
retest this please |
|
I'm told that the PR in question was zyga/snapd@16228ad which I didn't see in my email. I commented on that just now. |
|
I'm closing this pull request. I've improved on this branch in #1078 |
ssweeny commentedApr 18, 2016
This fixes a few issues with the bluez interface, specifically making the dbus policy permanent, fixing the label to match what we see in snappy, and allowing obexd to claim its dbus name.