Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
interfaces: add com.canonical.UrlLauncher.XdgOpen to unity7 interface #1167
Conversation
mvo5
added some commits
May 13, 2016
mvo5
changed the title from
interfaces: add com.canonical.SnappyUrlHelper.XdgOpen to unity7 interface
to
interfaces: add com.canonical.UrlLauncher.XdgOpen to unity7 interface
May 14, 2016
jdstrand
reviewed
May 16, 2016
| +dbus (send) | ||
| + bus=session | ||
| + interface=com.canonical.UrlLauncher.XdgOpen | ||
| + peer=(label=unconfined), |
jdstrand
May 16, 2016
Contributor
Can you comment on what this does, the XdgOpen API, etc? This rule is awfully open ended and seems like it would allow an application to launch arbitrary other applications, perhaps with arguments.
niemeyer
May 16, 2016
Contributor
This was a strawman. We're renaming it to com.canonical.URLLauncher, and must implement filtering of URLs on the server end. Actually, we should probably rename it to com.canonical.SafeLauncher instead, with an OpenURL method. WDYT, @mvo5?
niemeyer
reviewed
May 19, 2016
| +# url helper | ||
| +dbus (send) | ||
| + bus=session | ||
| + interface=com.canonical.UrlLauncher.XdgOpen |
mvo5
May 20, 2016
Collaborator
Done, thanks! I also updated snapcore/snapd-xdg-open@21e9c2b and https://launchpadlibrarian.net/260686704/livecd-rootfs_2.411~ppa3_2.411~ppa4.diff.gz
niemeyer
reviewed
May 19, 2016
| @@ -227,6 +233,7 @@ dbus (receive) | ||
| interface=org.freedesktop.Notifications | ||
| member=NotificationClosed | ||
| peer=(label=unconfined), | ||
| +>>>>>>> upstream/master |
|
LGTM with the two points addressed. |
mvo5 commentedMay 13, 2016
No description provided.