Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
cmd/snap: fix snap empty list text LP: #1587445 #1249
Conversation
|
Can one of the admins verify this patch? |
|
add to whitelist |
elopio
reviewed
Jun 1, 2016
| @@ -59,6 +59,9 @@ func listSnaps(args []string) error { | ||
| snaps, err := cli.ListSnaps(args) | ||
| if err != nil { | ||
| return err | ||
| + } else if len(snaps) == 0 { | ||
| + fmt.Println(i18n.G("No snaps are installed yet. Try 'snap install hello'.")) |
|
Thanks for your contribution, and welcome! |
thibran
commented
Jun 1, 2016
|
Hi all. I signed the CLA and fixed the string, what is left to do to get the patch merged? |
Paradiesstaub
added some commits
Jun 1, 2016
|
test this please |
|
(this is a comment to our CI system, the author of the patch doesn't have to do anything) |
|
Looks good to me, LGTM |
zyga
reviewed
Jun 1, 2016
| @@ -367,10 +367,12 @@ msgstr "" | ||
| msgid "no interfaces found" | ||
| msgstr "" | ||
| +msgid "No snaps are installed yet. Try 'snap install hello'." |
zyga
Jun 1, 2016
Contributor
This should be regenerated with ./update-pot but we can do that easily at release time.
|
|
mvo5
merged commit 48dc478
into
snapcore:master
Jun 1, 2016
zyga
changed the title from
fixed snap empty list text #1587445
to
cmd/snap: fix snap empty list text LP: #1587445
Jun 1, 2016
thibran
deleted the
thibran:fix_snap_list_lp1587445
branch
Jun 1, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
thibran commentedMay 31, 2016
This fixes the bit-size bug: https://bugs.launchpad.net/snappy/+bug/1587445
http://www.zygoon.pl/2016/05/bite-size-bugs-in-snapd.html