tests, integration-tests: port network interface test to spread

[fgimenez]

No description provided.

[zyga]

+1

[zyga]

The code looks good but tests fail:

+ echo Given a snap declaring the network plug is installed
Given a snap declaring the network plug is installed
+ snapbuild ../lib/snaps/network-consumer .
snapbuild: open ../lib/snaps/network-consumer/meta/snap.yaml: no such file or directory
-----
2016/06/22 08:00:34 Restoring linode:ubuntu-16.04-32-grub:tests/interfaces-network...
2016/06/22 08:00:34 Error restoring linode:ubuntu-16.04-32-grub:tests/interfaces-network : 
-----
+ sudo snap remove network-consumer
error: cannot remove "network-consumer": cannot find snap "network-consumer"

[zyga]

+1, except tests fail now

[fgimenez]

@zyga yep, a problem with the snap path, fixed.

Thanks!

[kyrofa]

autopkgtest is failing.

[fgimenez]

retest this please

[fgimenez]

@kyrofa yep mmm the failing test shouldn't be affected by these changes, the snaps have been copied, not moved, and are not changed, i've retriggered them to confirm the error

[niemeyer]

The summary should really be a be a one-line short summary. Something like "Ensure network interface works."

The content below is nice, though, and should go under:

details: |
    The network interface ...

[fgimenez]

Nice, done, didn't know before of the details key :)

[niemeyer]

Let's please not have 1m kill timeout on anything unless it's extremely trivial. Otherwise it's way too short.. any sort of network instability would kill the test, as has happened before in the other case we discussed yesterday.

Also note that the field is kill-timeout not kill-wait.

[fgimenez]

ok, removed

[niemeyer]

Can we please have the word "network" inlined instead of this variable? This is a constant really, and is used in contexts which are not about a plug, specifically. So it's obscuring the test rather than helping out.

[fgimenez]

Done, this could allow us to share common bits between all the interface tests, but now it isn't useful at all

[niemeyer]

Please drop all use of sudo. We're root.

[fgimenez]

ok done

[niemeyer]

Unused?

[fgimenez]

yes, this comes from the network-bind interface test, removed

[niemeyer]

This must not be required. We're resetting the state on the suite.

[niemeyer]

echo "GET / HTTP/1.0\n\n" > $REQUEST_FILE

But I believe REQUEST_FILE isn't being used at all?

[niemeyer]

rm -f on restore?

[fgimenez]

yes, that was missing

[niemeyer]

It's a good practice to first stop the activity, then remove content. Not sure if it makes a difference on this specific test, though.

[fgimenez]

yes, the service only depends on SERVICE_FILE, and it wasn't being removed :) Now it's in the right order, the service is stopped and the file removed afterwards