New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that Qt apps can export appmenu #1463

Merged
merged 1 commit into from Jul 1, 2016

Conversation

Projects
None yet
3 participants
@didrocks
Contributor

didrocks commented Jul 1, 2016

Test case:
clone https://github.com/ubuntu/snapcraft-desktop-helpers
cd demos/qt5 and snapcraft it.
Install without devmode, and see that the menubar isn't exported without
that apparmor profile patch.
-> appmenu-qt is exporting menus to /MenuBar/1 instead of /MenuBar

Ensure that Qt apps can export appmenu
Test case:
clone https://github.com/ubuntu/snapcraft-desktop-helpers
cd demos/qt5 and snapcraft it.
Install without devmode, and see that the menubar isn't exported without
that apparmor profile patch.
-> appmenu-qt is exporting menus to /MenuBar/1 instead of /MenuBar
@didrocks

This comment has been minimized.

Show comment
Hide comment
@didrocks

didrocks Jul 1, 2016

Contributor

(Thanks to seb for helping on this)

Contributor

didrocks commented Jul 1, 2016

(Thanks to seb for helping on this)

@mvo5

This comment has been minimized.

Show comment
Hide comment
@mvo5

mvo5 Jul 1, 2016

Collaborator

Nice! 👍

Collaborator

mvo5 commented Jul 1, 2016

Nice! 👍

@zyga

This comment has been minimized.

Show comment
Hide comment
@zyga

zyga Jul 1, 2016

Contributor

Looks good, thank you

Contributor

zyga commented Jul 1, 2016

Looks good, thank you

@zyga zyga merged commit 9f21ff7 into snapcore:master Jul 1, 2016

2 of 3 checks passed

autopkgtest
Details
Integration tests Success
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment