/snapd

Add Qt5 indicator support in unity7 interface #1519

Merged
merged 1 commit into from Jul 14, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@didrocks @jdstrand @mvo5
@didrocks
Contributor

didrocks commented Jul 8, 2016 •
Edited 1 time

Menus were blanked in Qt5 applications when running confined.
Adapt the unity7 interface to allow missing calls from sni-qt:

  • some properties are still under the com.canonical namespaces
  • some calls and signals are slightly different between KDE ones
    and ours (they mirror the appmenu ones)
  • path is different (under /menu)

That fixes https://bugs.launchpad.net/ubuntu/+source/snapd/+bug/1600138
@didrocks
Add Qt5 indicator support in unity7 interface 
Menus were blanked in Qt5 applications when running confined.
Adapt the unity7 interface to allow missing calls from sni-qt:
- some properties are still under the com.canonical namespaces
- some calls and signals are slightly different between KDE ones
  and ours (they mirror the appmenu ones)
- path is different (under /menu)

All checks have passed

3 successful checks
@snappy-m-o
Integration tests — Success
Details
@snappy-m-o
autopkgtest — Success
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
b98f1b8
@jdstrand
Contributor

jdstrand commented Jul 8, 2016

LGTM, +1
@mvo5
Collaborator

mvo5 commented Jul 8, 2016

👍 and we should merge once tests are green

@mvo5 mvo5 merged commit 75614de into snapcore:master Jul 14, 2016
3 checks passed

3 checks passed

Integration tests Success
Details
autopkgtest Success
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment