Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
many: add vendoring of dependencies by default #1785
Conversation
mvo5
added some commits
Aug 30, 2016
|
We should also adjust READMEs so that new contributors don't trip over |
|
Indeed, sorry for the missing README.md update. In fact I had it updated, but I forgot to git add, here it is now :) |
zyga
reviewed
Aug 30, 2016
| @@ -0,0 +1 @@ | ||
| +debian/tmp/usr/bin/uboot-go |
|
How do we generate a source tarball with vendored bits in place? |
|
It seems like debian/not-installed is not used on trusty. The ppa builds are failing for the /usr/bin/uboot-go not being installed. |
|
Looking at the errors it appears that gccgo does not support vendoring. We need to figure out what is doing on here. |
|
Why are you building with gccgo? Just for powerpc? I can find you a terrible patch to make vendoring sort of work with gccgo... |
|
@mwhudson yeah, just for gccgo. Thanks a bunch for the patch! |
mvo5
added some commits
Sep 19, 2016
| - golang-yaml.v2-dev, | ||
| - golang-gopkg-macaroon.v1-dev, | ||
| - golang-gopkg-tomb.v2-dev, | ||
| - golang-websocket-dev, |
| @@ -12,6 +12,14 @@ export PATH:=${PATH}:${CURDIR} | ||
| RELEASE = $(shell lsb_release -c -s) | ||
| +# The go tool does not fully support vendoring with gccgo, but we can | ||
| +# work around that by constructing the appropriate -I flag by hand. |
niemeyer
Sep 19, 2016
•
Edited 1 time
-
niemeyer
Sep 19, 2016
Contributor
-
Sep 19, 2016
Yeah, ouch.. nice we can workaround at least.
|
Tests are broken. |
niemeyer
added
the
Reviewed
label
Sep 19, 2016
mvo5
added some commits
Sep 20, 2016
|
Test failures: |
mvo5 commentedAug 30, 2016
This is a preview for the vendoring support.