Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
many: use snap.ConfinementType rather than bool devmode #2315
Conversation
All checks have passed
zyga
referenced this pull request
Nov 21, 2016
Closed
many: fix handling of jail mode in security setup #2310
niemeyer
merged commit ff7b608
into
snapcore:master
Nov 21, 2016
zyga
deleted the
zyga:confinement-api
branch
Nov 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
zyga commentedNov 21, 2016
•
Edited 1 time
-
zyga
Nov 21, 2016
This large patch semi-mechanically changes all of devMode bool flag to
snap.ConfinementType with values such as DevmodeConfinement (old true)
and StrictConfinement (old false).
The intent is to have more than two states (so that we can have classic
confinement later) and so that the effective confinement is conveyed,
regardless of flags such as devmode and jailmode elsewhere.
The code in the interface manager is kept as-is (same logic as before,
just trivial adjustments to let it compile) so that a subsequent branch
can use EffectiveConfinement and fix the jailmode bug neatly.
Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com